* [PATCH] xen: fix sparse warning in page.h
@ 2014-12-05 6:16 Juergen Gross
0 siblings, 0 replies; only message in thread
From: Juergen Gross @ 2014-12-05 6:16 UTC (permalink / raw)
To: linux-kernel, xen-devel, konrad.wilk, david.vrabel, boris.ostrovsky
Cc: Juergen Gross
The inline function mfn_to_pfn_no_overrides() uses __get_user() to
access the machine_to_phys_mapping array to avoid crashes when
using out of bounds indices e.g. for I/O addresses.
Avoid sparse warnings by attributing the accessed address with __user.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
arch/x86/include/asm/xen/page.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/xen/page.h b/arch/x86/include/asm/xen/page.h
index f5d5de4..6deff84 100644
--- a/arch/x86/include/asm/xen/page.h
+++ b/arch/x86/include/asm/xen/page.h
@@ -113,6 +113,7 @@ static inline unsigned long mfn_to_pfn_no_overrides(unsigned long mfn)
{
unsigned long pfn;
int ret;
+ unsigned long __user *addr;
if (xen_feature(XENFEAT_auto_translated_physmap))
return mfn;
@@ -125,7 +126,8 @@ static inline unsigned long mfn_to_pfn_no_overrides(unsigned long mfn)
* In such cases it doesn't matter what we return (we return garbage),
* but we must handle the fault without crashing!
*/
- ret = __get_user(pfn, &machine_to_phys_mapping[mfn]);
+ addr = (unsigned long __user *)(&machine_to_phys_mapping[mfn]);
+ ret = __get_user(pfn, addr);
if (ret < 0)
return ~0;
--
2.1.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-12-05 6:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-05 6:16 [PATCH] xen: fix sparse warning in page.h Juergen Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®