* [PATCH] Drivers:watchdog: Fixed missing blank line warning
@ 2014-12-05 12:59 Athira Lekshmi
2014-12-05 13:27 ` Jeremiah Mahler
0 siblings, 1 reply; 2+ messages in thread
From: Athira Lekshmi @ 2014-12-05 12:59 UTC (permalink / raw)
To: wim; +Cc: linux-kernel, linux-watchdog, Athira Lekshmi
Fixed the checkpatch warning:
Missing a blank line after declarations
Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
---
drivers/watchdog/mixcomwd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/mixcomwd.c b/drivers/watchdog/mixcomwd.c
index be86ea3..03b7612e 100644
--- a/drivers/watchdog/mixcomwd.c
+++ b/drivers/watchdog/mixcomwd.c
@@ -183,6 +183,7 @@ static ssize_t mixcomwd_write(struct file *file, const char __user *data,
for (i = 0; i != len; i++) {
char c;
+
if (get_user(c, data + i))
return -EFAULT;
if (c == 'V')
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Drivers:watchdog: Fixed missing blank line warning
2014-12-05 12:59 [PATCH] Drivers:watchdog: Fixed missing blank line warning Athira Lekshmi
@ 2014-12-05 13:27 ` Jeremiah Mahler
0 siblings, 0 replies; 2+ messages in thread
From: Jeremiah Mahler @ 2014-12-05 13:27 UTC (permalink / raw)
To: Athira Lekshmi; +Cc: linux-kernel
Athira,
On Fri, Dec 05, 2014 at 06:29:00PM +0530, Athira Lekshmi wrote:
> Fixed the checkpatch warning:
> Missing a blank line after declarations
>
> Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
> ---
> drivers/watchdog/mixcomwd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/mixcomwd.c b/drivers/watchdog/mixcomwd.c
> index be86ea3..03b7612e 100644
> --- a/drivers/watchdog/mixcomwd.c
> +++ b/drivers/watchdog/mixcomwd.c
> @@ -183,6 +183,7 @@ static ssize_t mixcomwd_write(struct file *file, const char __user *data,
>
> for (i = 0; i != len; i++) {
> char c;
> +
> if (get_user(c, data + i))
> return -EFAULT;
> if (c == 'V')
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
There should be spaces between the tags in your subject line. For
example, instead of "Drivers:watchdog:" use "Drivers: watchdog:".
And the tags should be useful, I am not sure if "Drivers" adds much.
I would probably just use "watchdog:" in this case.
--
- Jeremiah Mahler
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-05 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-05 12:59 [PATCH] Drivers:watchdog: Fixed missing blank line warning Athira Lekshmi
2014-12-05 13:27 ` Jeremiah Mahler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®