From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/8] lib: bitmap: More signed->unsigned conversions
Date: Fri, 12 Dec 2014 01:01:47 +0100 [thread overview]
Message-ID: <1418342514-21630-2-git-send-email-linux@rasmusvillemoes.dk> (raw)
In-Reply-To: <1418342514-21630-1-git-send-email-linux@rasmusvillemoes.dk>
For consistency with the other bitmap_* functions, also make the nbits
parameter of bitmap_zero, bitmap_fill and bitmap_copy unsigned.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
include/linux/bitmap.h | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
index e1c8d080c427..0106f02e5a93 100644
--- a/include/linux/bitmap.h
+++ b/include/linux/bitmap.h
@@ -156,33 +156,33 @@ extern int bitmap_ord_to_pos(const unsigned long *bitmap, int n, int bits);
#define small_const_nbits(nbits) \
(__builtin_constant_p(nbits) && (nbits) <= BITS_PER_LONG)
-static inline void bitmap_zero(unsigned long *dst, int nbits)
+static inline void bitmap_zero(unsigned long *dst, unsigned int nbits)
{
if (small_const_nbits(nbits))
*dst = 0UL;
else {
- int len = BITS_TO_LONGS(nbits) * sizeof(unsigned long);
+ unsigned int len = BITS_TO_LONGS(nbits) * sizeof(unsigned long);
memset(dst, 0, len);
}
}
-static inline void bitmap_fill(unsigned long *dst, int nbits)
+static inline void bitmap_fill(unsigned long *dst, unsigned int nbits)
{
- size_t nlongs = BITS_TO_LONGS(nbits);
+ unsigned int nlongs = BITS_TO_LONGS(nbits);
if (!small_const_nbits(nbits)) {
- int len = (nlongs - 1) * sizeof(unsigned long);
+ unsigned int len = (nlongs - 1) * sizeof(unsigned long);
memset(dst, 0xff, len);
}
dst[nlongs - 1] = BITMAP_LAST_WORD_MASK(nbits);
}
static inline void bitmap_copy(unsigned long *dst, const unsigned long *src,
- int nbits)
+ unsigned int nbits)
{
if (small_const_nbits(nbits))
*dst = *src;
else {
- int len = BITS_TO_LONGS(nbits) * sizeof(unsigned long);
+ unsigned int len = BITS_TO_LONGS(nbits) * sizeof(unsigned long);
memcpy(dst, src, len);
}
}
--
2.1.3
next prev parent reply other threads:[~2014-12-12 0:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 0:01 [PATCH 0/8] lib: bitmap: Another small series Rasmus Villemoes
2014-12-12 0:01 ` Rasmus Villemoes [this message]
2014-12-12 0:01 ` [PATCH 2/8] linux/nodemask.h: Update bitmap wrappers to take unsigned int Rasmus Villemoes
2014-12-12 0:01 ` [PATCH 3/8] linux/cpumask.h: " Rasmus Villemoes
2014-12-12 0:01 ` [PATCH 4/8] lib: bitmap: Update bitmap_onto to unsigned Rasmus Villemoes
2014-12-12 0:01 ` [PATCH 5/8] lib: bitmap: Change parameters of bitmap_fold " Rasmus Villemoes
2014-12-12 0:01 ` [PATCH 6/8] lib: bitmap: Simplify bitmap_pos_to_ord Rasmus Villemoes
2014-12-12 0:01 ` [PATCH 7/8] lib: bitmap: Simplify bitmap_ord_to_pos Rasmus Villemoes
2014-12-12 0:01 ` [PATCH 8/8] lib: bitmap: Minor changes of bitmap_remap Rasmus Villemoes
2014-12-18 21:56 ` [PATCH 8/8 v2] lib: bitmap: Make the bits parameter of bitmap_remap unsigned Rasmus Villemoes
2014-12-19 9:23 ` [PATCH v3] " Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418342514-21630-2-git-send-email-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®