mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 5/8] lib: bitmap: Change parameters of bitmap_fold to unsigned
Date: Fri, 12 Dec 2014 01:01:51 +0100	[thread overview]
Message-ID: <1418342514-21630-6-git-send-email-linux@rasmusvillemoes.dk> (raw)
In-Reply-To: <1418342514-21630-1-git-send-email-linux@rasmusvillemoes.dk>

Change the sz and nbits parameters of bitmap_fold to unsigned int for
consistency with other bitmap_* functions, and to save another few
bytes in the generated code.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 include/linux/bitmap.h | 2 +-
 lib/bitmap.c           | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
index bf29a08bb3db..85e8fb091ed7 100644
--- a/include/linux/bitmap.h
+++ b/include/linux/bitmap.h
@@ -139,7 +139,7 @@ extern int bitmap_bitremap(int oldbit,
 extern void bitmap_onto(unsigned long *dst, const unsigned long *orig,
 		const unsigned long *relmap, unsigned int bits);
 extern void bitmap_fold(unsigned long *dst, const unsigned long *orig,
-		int sz, int bits);
+		unsigned int sz, unsigned int nbits);
 extern int bitmap_find_free_region(unsigned long *bitmap, unsigned int bits, int order);
 extern void bitmap_release_region(unsigned long *bitmap, unsigned int pos, int order);
 extern int bitmap_allocate_region(unsigned long *bitmap, unsigned int pos, int order);
diff --git a/lib/bitmap.c b/lib/bitmap.c
index 42d5886c3680..1807d089eda7 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -1015,15 +1015,15 @@ EXPORT_SYMBOL(bitmap_onto);
  * Example [2] for bitmap_onto() for why and how to use this.
  */
 void bitmap_fold(unsigned long *dst, const unsigned long *orig,
-			int sz, int bits)
+			unsigned int sz, unsigned int nbits)
 {
-	int oldbit;
+	unsigned int oldbit;
 
 	if (dst == orig)	/* following doesn't handle inplace mappings */
 		return;
-	bitmap_zero(dst, bits);
+	bitmap_zero(dst, nbits);
 
-	for_each_set_bit(oldbit, orig, bits)
+	for_each_set_bit(oldbit, orig, nbits)
 		set_bit(oldbit % sz, dst);
 }
 EXPORT_SYMBOL(bitmap_fold);
-- 
2.1.3


  parent reply	other threads:[~2014-12-12  0:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-12  0:01 [PATCH 0/8] lib: bitmap: Another small series Rasmus Villemoes
2014-12-12  0:01 ` [PATCH 1/8] lib: bitmap: More signed->unsigned conversions Rasmus Villemoes
2014-12-12  0:01 ` [PATCH 2/8] linux/nodemask.h: Update bitmap wrappers to take unsigned int Rasmus Villemoes
2014-12-12  0:01 ` [PATCH 3/8] linux/cpumask.h: " Rasmus Villemoes
2014-12-12  0:01 ` [PATCH 4/8] lib: bitmap: Update bitmap_onto to unsigned Rasmus Villemoes
2014-12-12  0:01 ` Rasmus Villemoes [this message]
2014-12-12  0:01 ` [PATCH 6/8] lib: bitmap: Simplify bitmap_pos_to_ord Rasmus Villemoes
2014-12-12  0:01 ` [PATCH 7/8] lib: bitmap: Simplify bitmap_ord_to_pos Rasmus Villemoes
2014-12-12  0:01 ` [PATCH 8/8] lib: bitmap: Minor changes of bitmap_remap Rasmus Villemoes
2014-12-18 21:56   ` [PATCH 8/8 v2] lib: bitmap: Make the bits parameter of bitmap_remap unsigned Rasmus Villemoes
2014-12-19  9:23     ` [PATCH v3] " Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418342514-21630-6-git-send-email-linux@rasmusvillemoes.dk \
    --to=linux@rasmusvillemoes.dk \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®