mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/12] ACPI: Rework the handling of power resources
Date: Fri, 04 Jan 2013 00:16:48 +0100	[thread overview]
Message-ID: <1418767.4KIZOTK1lk@vostro.rjw.lan> (raw)

Hi All,

There are some problems with our handling of ACPI power resources that have
accumulated over time or have never been addressed.

First of all, the interface represented by
acpi_power_resource_[un]register_device() doesn't really work as it should,
so it needs to be redesigned (details in the changelog of patch [1/12]).

Second, power resources really have to be treated in a special way by the
ACPI namespace scanning code, because they may need to be ready to use as
soon as they are discovered.  Moreover, the are represented by struct
acpi_device objects, so that they appear in sysfs along with "regular" ACPI
device nodes, they really don't represent devices, so they need special
configuration treatment in some cases.  This special casing is obnoxiously
present in scan.c, but if we accept the fact that power resources really are
a special case, things can be simplified quite a bit (patch [3/12] with some
preparations in [2/12]).

If the above changes are made, then it turns out that the entire
acpi_power_driver structure is not necessary any more and we don't need the
device power states of power resources for anything (patches [4-5/12]).

Moreover, ACPI power resources are supposed to be ordered.  Namely, they have
an attribute defining the order in which they are supposed to turned on and
off.  Currently, though, we don't take that attribute into accound, although
we obviously should do that.  After the previous changes that may be
implemented at a relatively low cost (patch [6-7/12]).

Patches [8-9/12] move code around and clean it up in preparation for patch
[10/12], which consolidates the way in which power resources lists are
extracted from the output of _PRW and _PR[0-3].

Patch [11/12] improves the handling of power resource initialization errors
and patch [12/12] causes the system level attribute of wakeup power resources
to be taken into account during device setup.

All patches are on top of the git branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next

Tested on HP nx6325 (and other boxes where ACPI power resources aren't used).

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

             reply	other threads:[~2013-01-04  0:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-03 23:16 Rafael J. Wysocki [this message]
2013-01-04  0:01 ` [PATCH 1/12] ACPI / PM: Rework the handling of devices depending on " Rafael J. Wysocki
2013-01-04  0:02 ` [PATCH 2/12] ACPI / scan: More straightforward preparation of ACPI device objects Rafael J. Wysocki
2013-01-04  0:03 ` [PATCH 3/12] ACPI / scan: Treat power resources in a special way Rafael J. Wysocki
2013-01-04  0:03 ` [PATCH 4/12] ACPI: Drop power resources driver Rafael J. Wysocki
2013-01-04  0:04 ` [PATCH 5/12] ACPI: Do not use device power states of power resources Rafael J. Wysocki
2013-01-04  0:05 ` [PATCH 6/12] ACPI / PM: Take order attribute of power resources into account Rafael J. Wysocki
2013-01-04  0:06 ` [PATCH 7/12] ACPI / PM: Take order attribute of wakeup " Rafael J. Wysocki
2013-01-04  0:07 ` [PATCH 8/12] ACPI / scan: Move power state initialization to a separate routine Rafael J. Wysocki
2013-01-04  0:07 ` [PATCH 9/12] ACPI / scan: Remove unnecessary initialization of local variables Rafael J. Wysocki
2013-01-04  0:08 ` [PATCH 10/12] ACPI / scan: Consolidate extraction of power resources lists Rafael J. Wysocki
2013-01-04  0:09 ` [PATCH 11/12] ACPI: Take power resource initialization errors into account Rafael J. Wysocki
2013-01-04  0:10 ` [PATCH 12/12] ACPI: Use system level attribute of wakeup power resources Rafael J. Wysocki
2013-01-11 21:57 ` [PATCH 0/12] ACPI: Rework the handling of " Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418767.4KIZOTK1lk@vostro.rjw.lan \
    --to=rjw@sisk.pl \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®