mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Hariharan Rangasamy <hariharanrangasamy@gmail.com>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
	gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() instead of seq_printf()
Date: Wed, 17 Dec 2014 10:22:30 -0800	[thread overview]
Message-ID: <1418840550.14140.27.camel@perches.com> (raw)
In-Reply-To: <1418839168-7921-2-git-send-email-hariharanrangasamy@gmail.com>

On Wed, 2014-12-17 at 23:29 +0530, Hariharan Rangasamy wrote:
> Replaced seq_printf() with seq_puts()
[]
> diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c
[]
> @@ -358,7 +358,7 @@ static int osc_checksum_type_seq_show(struct seq_file *m, void *v)
>  		else
>  			seq_printf(m, "%s ", cksum_name[i]);
>  	}
> -	seq_printf(m, "\n");
> +	seq_puts(m, "\n");

This could be seq_putc

>  	return 0;
>  }
>  
> @@ -590,7 +590,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
>  	seq_printf(seq, "pending read pages:   %d\n",
>  		   atomic_read(&cli->cl_pending_r_pages));
>  
> -	seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
> +	seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
>  	seq_printf(seq, "pages per rpc	 rpcs   %% cum %% |");
>  	seq_printf(seq, "       rpcs   %% cum %%\n");

These and others could be seq_puts too, just use % instead of %%



      reply	other threads:[~2014-12-17 18:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17 17:59 [PATCH 1/2] Staging: lustre: lproc_osc.c : Added #include <linux/statfs.h> instead of #include <asm/statfs.h> Hariharan Rangasamy
2014-12-17 17:59 ` [PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() instead of seq_printf() Hariharan Rangasamy
2014-12-17 18:22   ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418840550.14140.27.camel@perches.com \
    --to=joe@perches.com \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hariharanrangasamy@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®