[PATCH 1/2] Staging: lustre: lproc_osc.c : Added #include <linux/statfs.h> instead of #include <asm/statfs.h>

[PATCH 1/2] Staging: lustre: lproc_osc.c : Added #include <linux/statfs.h> instead of #include <asm/statfs.h>

[Hariharan Rangasamy]

Used #include <linux/statfs.h> instead of #include <asm/statfs.h>

Signed-off-by: Hariharan Rangasamy <hariharanrangasamy@gmail.com>
---
 drivers/staging/lustre/lustre/osc/lproc_osc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c
index 9f719bc..f578b51 100644
--- a/drivers/staging/lustre/lustre/osc/lproc_osc.c
+++ b/drivers/staging/lustre/lustre/osc/lproc_osc.c
@@ -35,7 +35,7 @@
  */
 #define DEBUG_SUBSYSTEM S_CLASS
 
-#include <asm/statfs.h>
+#include <linux/statfs.h>
 #include "../include/obd_cksum.h"
 #include "../include/obd_class.h"
 #include "../include/lprocfs_status.h"
-- 
1.9.1

[PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() instead of seq_printf()

[Hariharan Rangasamy]

Replaced seq_printf() with seq_puts()

Signed-off-by: Hariharan Rangasamy <hariharanrangasamy@gmail.com>
---
 drivers/staging/lustre/lustre/osc/lproc_osc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c
index f578b51..d64a400 100644
--- a/drivers/staging/lustre/lustre/osc/lproc_osc.c
+++ b/drivers/staging/lustre/lustre/osc/lproc_osc.c
@@ -358,7 +358,7 @@ static int osc_checksum_type_seq_show(struct seq_file *m, void *v)
 		else
 			seq_printf(m, "%s ", cksum_name[i]);
 	}
-	seq_printf(m, "\n");
+	seq_puts(m, "\n");
 	return 0;
 }
 
@@ -590,7 +590,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
 	seq_printf(seq, "pending read pages:   %d\n",
 		   atomic_read(&cli->cl_pending_r_pages));
 
-	seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
+	seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
 	seq_printf(seq, "pages per rpc	 rpcs   %% cum %% |");
 	seq_printf(seq, "       rpcs   %% cum %%\n");
 
@@ -613,7 +613,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
 			break;
 	}
 
-	seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
+	seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
 	seq_printf(seq, "rpcs in flight	rpcs   %% cum %% |");
 	seq_printf(seq, "       rpcs   %% cum %%\n");
 
@@ -636,7 +636,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
 			break;
 	}
 
-	seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
+	seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
 	seq_printf(seq, "offset		rpcs   %% cum %% |");
 	seq_printf(seq, "       rpcs   %% cum %%\n");
 
-- 
1.9.1

Re: [PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() instead of seq_printf()

[Joe Perches]

On Wed, 2014-12-17 at 23:29 +0530, Hariharan Rangasamy wrote:
> Replaced seq_printf() with seq_puts()
[]
> diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c
[]
> @@ -358,7 +358,7 @@ static int osc_checksum_type_seq_show(struct seq_file *m, void *v)
>  		else
>  			seq_printf(m, "%s ", cksum_name[i]);
>  	}
> -	seq_printf(m, "\n");
> +	seq_puts(m, "\n");

This could be seq_putc

>  	return 0;
>  }
>  
> @@ -590,7 +590,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
>  	seq_printf(seq, "pending read pages:   %d\n",
>  		   atomic_read(&cli->cl_pending_r_pages));
>  
> -	seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
> +	seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
>  	seq_printf(seq, "pages per rpc	 rpcs   %% cum %% |");
>  	seq_printf(seq, "       rpcs   %% cum %%\n");

These and others could be seq_puts too, just use % instead of %%