From: Lucas Stach <l.stach@pengutronix.de>
To: nick <xerofoify@gmail.com>
Cc: "Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
inki.dae@samsung.com, linux-fbdev@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, dh09.lee@samsung.com,
linux-kernel@vger.kernel.org, kyungmin.park@samsung.com,
tomi.valkeinen@ti.com, kgene@kernel.org, plagnioj@jcrosoft.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c
Date: Thu, 18 Dec 2014 14:39:38 +0100 [thread overview]
Message-ID: <1418909978.2236.0.camel@pengutronix.de> (raw)
In-Reply-To: <5492D80E.3010906@gmail.com>
Am Donnerstag, den 18.12.2014, 08:35 -0500 schrieb nick:
> Krzysztof,
> If we look at the code for this function, it already is handling the data correctly. In addition the locks
> seem to be better protection then msleep. Further more is no reason for this delay as we are neither resetting
> the hardware or waiting for the hardware here so why is it needed? I don't have Exynos based hardware lying
> around through to test it.
If you can't test it, don't touch it. It's that simple.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-12-18 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54920A54.2060608@gmail.com>
2014-12-18 10:26 ` Krzysztof Kozłowski
[not found] ` <5492D80E.3010906@gmail.com>
2014-12-18 13:39 ` Lucas Stach [this message]
[not found] ` <5492DB1A.2020704@gmail.com>
2014-12-18 14:05 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418909978.2236.0.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=dh09.lee@samsung.com \
--cc=inki.dae@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®