* [PATCH v2] checkpatch: fix UNNECESSARY_KERN_LEVEL false positive
@ 2014-12-23 13:31 Paolo Bonzini
2014-12-23 13:41 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2014-12-23 13:31 UTC (permalink / raw)
To: linux-kernel; +Cc: Andy Whitcroft, Joe Perches, Andrew Morton
KERN_<LEVEL> is never redundant with printk_ratelimited or printk_once.
(Except perhaps in the sense that you could use e.g. pr_err_ratelimited
or pr_err_once, but that would apply to printk as well).
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
v1->v2: skip printk_once too [Joe Perches]
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f0bb6d60c07b..350cd692a138 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4545,7 +4545,7 @@ sub process {
}
# check for logging functions with KERN_<LEVEL>
- if ($line !~ /printk\s*\(/ &&
+ if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ &&
$line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {
my $level = $1;
if (WARN("UNNECESSARY_KERN_LEVEL",
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] checkpatch: fix UNNECESSARY_KERN_LEVEL false positive
2014-12-23 13:31 [PATCH v2] checkpatch: fix UNNECESSARY_KERN_LEVEL false positive Paolo Bonzini
@ 2014-12-23 13:41 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2014-12-23 13:41 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: linux-kernel, Andy Whitcroft, Andrew Morton
On Tue, 2014-12-23 at 14:31 +0100, Paolo Bonzini wrote:
> KERN_<LEVEL> is never redundant with printk_ratelimited or printk_once.
> (Except perhaps in the sense that you could use e.g. pr_err_ratelimited
> or pr_err_once, but that would apply to printk as well).
[]
> v1->v2: skip printk_once too [Joe Perches]
Thanks,
Acked-by: Joe Perches <joe@perches.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-23 13:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-23 13:31 [PATCH v2] checkpatch: fix UNNECESSARY_KERN_LEVEL false positive Paolo Bonzini
2014-12-23 13:41 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome