[PATCH] x86: Fix multiple coding style issues

[PATCH] x86: Fix multiple coding style issues

[Alexander Kuleshov]

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 arch/x86/boot/header.S | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
index 16ef025..75f016b 100644
--- a/arch/x86/boot/header.S
+++ b/arch/x86/boot/header.S
@@ -211,7 +211,8 @@ section_table:
 	.long	0				# PointerToLineNumbers
 	.word	0				# NumberOfRelocations
 	.word	0				# NumberOfLineNumbers
-	.long	0x60500020			# Characteristics (section flags)
+	.long	0x60500020			# Characteristics
+						# (section flags)
 
 	#
 	# The EFI application loader requires a relocation section
@@ -229,7 +230,8 @@ section_table:
 	.long	0				# PointerToLineNumbers
 	.word	0				# NumberOfRelocations
 	.word	0				# NumberOfLineNumbers
-	.long	0x42100040			# Characteristics (section flags)
+	.long	0x42100040			# Characteristics
+						# (section flags)
 
 	#
 	# The offset & size fields are filled in by build.c.
@@ -247,7 +249,8 @@ section_table:
 	.long	0				# PointerToLineNumbers
 	.word	0				# NumberOfRelocations
 	.word	0				# NumberOfLineNumbers
-	.long	0x60500020			# Characteristics (section flags)
+	.long	0x60500020			# Characteristics
+						# (section flags)
 
 	#
 	# The offset & size fields are filled in by build.c.
@@ -266,7 +269,8 @@ section_table:
 	.long	0				# PointerToLineNumbers
 	.word	0				# NumberOfRelocations
 	.word	0				# NumberOfLineNumbers
-	.long	0xc8000080			# Characteristics (section flags)
+	.long	0xc8000080			# Characteristics
+						# (section flags)
 
 #endif /* CONFIG_EFI_STUB */
 
@@ -426,7 +430,8 @@ cmdline_size:   .long   COMMAND_LINE_SIZE-1     #length of the command line,
                                                 #added with boot protocol
                                                 #version 2.06
 
-hardware_subarch:	.long 0			# subarchitecture, added with 2.07
+hardware_subarch:	.long 0			# subarchitecture,
+						# added with 2.07
 						# default to 0 for normal x86 PC
 
 hardware_subarch_data:	.quad 0
-- 
2.2.1.202.g98acd41

Re: [PATCH] x86: Fix multiple coding style issues

[Jeremiah Mahler]

Alexander,

On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:

Your description needs to be more specific than just "coding style
fixes".  What type of problems did you fix?  How did you find them?

(more inline...)

> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
>  arch/x86/boot/header.S | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index 16ef025..75f016b 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -211,7 +211,8 @@ section_table:
>  	.long	0				# PointerToLineNumbers
>  	.word	0				# NumberOfRelocations
>  	.word	0				# NumberOfLineNumbers
> -	.long	0x60500020			# Characteristics (section flags)
> +	.long	0x60500020			# Characteristics
> +						# (section flags)
>  
>  	#
>  	# The EFI application loader requires a relocation section
> @@ -229,7 +230,8 @@ section_table:
>  	.long	0				# PointerToLineNumbers
>  	.word	0				# NumberOfRelocations
>  	.word	0				# NumberOfLineNumbers
> -	.long	0x42100040			# Characteristics (section flags)
> +	.long	0x42100040			# Characteristics
> +						# (section flags)
>  
>  	#
>  	# The offset & size fields are filled in by build.c.
> @@ -247,7 +249,8 @@ section_table:
>  	.long	0				# PointerToLineNumbers
>  	.word	0				# NumberOfRelocations
>  	.word	0				# NumberOfLineNumbers
> -	.long	0x60500020			# Characteristics (section flags)
> +	.long	0x60500020			# Characteristics
> +						# (section flags)
>  
>  	#
>  	# The offset & size fields are filled in by build.c.
> @@ -266,7 +269,8 @@ section_table:
>  	.long	0				# PointerToLineNumbers
>  	.word	0				# NumberOfRelocations
>  	.word	0				# NumberOfLineNumbers
> -	.long	0xc8000080			# Characteristics (section flags)
> +	.long	0xc8000080			# Characteristics
> +						# (section flags)
>  
>  #endif /* CONFIG_EFI_STUB */
>  
> @@ -426,7 +430,8 @@ cmdline_size:   .long   COMMAND_LINE_SIZE-1     #length of the command line,
>                                                  #added with boot protocol
>                                                  #version 2.06
>  
> -hardware_subarch:	.long 0			# subarchitecture, added with 2.07
> +hardware_subarch:	.long 0			# subarchitecture,
> +						# added with 2.07
>  						# default to 0 for normal x86 PC
>  
>  hardware_subarch_data:	.quad 0
> -- 
> 2.2.1.202.g98acd41
> 

It looks like your fixes are for lines being over 80 characters.  While
it is preferrable that lines be less than 80 characters it is still
acceptable if they are longer.

If you are looking for things to fix I suggest looking in the
drivers/staging directory.  There are lots of things that need to be
fixed in there.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
- Jeremiah Mahler

Re: [PATCH] x86: Fix multiple coding style issues

[Alexander Kuleshov]

Hello Jeremiah,

Thank you for feedback. It is my first patches to kernel, so i have a
some little questions:

> Jeremiah Mahler <jmmahler@gmail.com>:
> Alexander,
>
> On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:
>
> Your description needs to be more specific than just "coding style
> fixes".  What type of problems did you fix?  How did you find them?
>

There are some lines which more than 80 chars, I found it with
scripts/checkpatch.pl.
What is the best place to put this description? In commit message
after first line?

> Jeremiah Mahler <jmmahler@gmail.com>:
> If you are looking for things to fix I suggest looking in the
> drivers/staging directory.  There are lots of things that need to be
> fixed in there.

So i must make this patch for kernel/git/gregkh/staging.git and resend
it again or just to add to this thread?
Or i'm wrong?

Thank you.

Re: [PATCH] x86: Fix multiple coding style issues

[Alexander Kuleshov]

> Jeremiah Mahler <jmmahler@gmail.com>:
If you are looking for things to fix I suggest looking in the
drivers/staging directory.  There are lots of things that need to be
fixed in there.

Ah sorry, read it incorrectly.

2014-12-26 23:09 GMT+06:00 Alexander Kuleshov <kuleshovmail@gmail.com>:
> Hello Jeremiah,
>
> Thank you for feedback. It is my first patches to kernel, so i have a
> some little questions:
>
>> Jeremiah Mahler <jmmahler@gmail.com>:
>> Alexander,
>>
>> On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:
>>
>> Your description needs to be more specific than just "coding style
>> fixes".  What type of problems did you fix?  How did you find them?
>>
>
> There are some lines which more than 80 chars, I found it with
> scripts/checkpatch.pl.
> What is the best place to put this description? In commit message
> after first line?
>
>> Jeremiah Mahler <jmmahler@gmail.com>:
>> If you are looking for things to fix I suggest looking in the
>> drivers/staging directory.  There are lots of things that need to be
>> fixed in there.
>
> So i must make this patch for kernel/git/gregkh/staging.git and resend
> it again or just to add to this thread?
> Or i'm wrong?
>
> Thank you.



-- 
_________________________
0xAX

Re: [PATCH] x86: Fix multiple coding style issues

[Jeremiah Mahler]

Alexander,

On Fri, Dec 26, 2014 at 11:09:53PM +0600, Alexander Kuleshov wrote:
> Hello Jeremiah,
> 
> Thank you for feedback. It is my first patches to kernel, so i have a
> some little questions:
> 
I recommend checking out Greg Kroah Hartman's presentation on submitting
your first patch.  It has lots of good tips.

https://www.youtube.com/watch?v=LLBrBBImJt4

> > Jeremiah Mahler <jmmahler@gmail.com>:
> > Alexander,
> >
> > On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:
> >
> > Your description needs to be more specific than just "coding style
> > fixes".  What type of problems did you fix?  How did you find them?
> >
> 
> There are some lines which more than 80 chars, I found it with
> scripts/checkpatch.pl.
> What is the best place to put this description? In commit message
> after first line?
> 

Yes, just put that in the log message.  The first line is the summary,
then a blank line, then the detailed log message.  The summary line is
what ends up in the subject line of the email.

> > Jeremiah Mahler <jmmahler@gmail.com>:
> > If you are looking for things to fix I suggest looking in the
> > drivers/staging directory.  There are lots of things that need to be
> > fixed in there.
> 
> So i must make this patch for kernel/git/gregkh/staging.git and resend
> it again or just to add to this thread?
> Or i'm wrong?
> 
You figured this out in your next message :)

> Thank you.

Glad I could help :)
-- 
- Jeremiah Mahler