From: <dinguyen@opensource.altera.com>
To: <dwmw2@infradead.org>
Cc: <dinh.linux@gmail.com>, <computersforpeace@gmail.com>,
<yamada.m@jp.panasonic.com>, <josh@joshtriplett.org>,
<shijie8@gmail.com>, <linux-mtd@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Graham Moore <grmoore@opensource.altera.com>,
Dinh Nguyen <dinguyen@opensource.altera.com>
Subject: [PATCH] mtd: denali: fix incorrect bitmask error in denali_setup_dma
Date: Fri, 9 Jan 2015 09:32:35 -0600 [thread overview]
Message-ID: <1420817555-22828-1-git-send-email-dinguyen@opensource.altera.com> (raw)
From: Graham Moore <grmoore@opensource.altera.com>
commit "3157d1ed2309 mtd: denali: remove unnecessary casts" introduced
an error by using a wrong bitmask.
A uint16_t cast was replaced with & 0xff, should be & 0xffff.
Signed-off-by: Graham Moore <grmoore@opensource.altera.com>
Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
---
drivers/mtd/nand/denali.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index b3b7ca1..5e397fb 100644
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -1041,7 +1041,7 @@ static void denali_setup_dma(struct denali_nand_info *denali, int op)
index_addr(denali, mode | ((addr >> 16) << 8), 0x2200);
/* 3. set memory low address bits 23:8 */
- index_addr(denali, mode | ((addr & 0xff) << 8), 0x2300);
+ index_addr(denali, mode | ((addr & 0xffff) << 8), 0x2300);
/* 4. interrupt when complete, burst len = 64 bytes */
index_addr(denali, mode | 0x14000, 0x2400);
--
1.7.9.5
next reply other threads:[~2015-01-09 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 15:32 dinguyen [this message]
2015-01-13 10:33 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420817555-22828-1-git-send-email-dinguyen@opensource.altera.com \
--to=dinguyen@opensource.altera.com \
--cc=computersforpeace@gmail.com \
--cc=dinh.linux@gmail.com \
--cc=dwmw2@infradead.org \
--cc=grmoore@opensource.altera.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shijie8@gmail.com \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®