* [PATCH] mtd: denali: fix incorrect bitmask error in denali_setup_dma
@ 2015-01-09 15:32 dinguyen
2015-01-13 10:33 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: dinguyen @ 2015-01-09 15:32 UTC (permalink / raw)
To: dwmw2
Cc: dinh.linux, computersforpeace, yamada.m, josh, shijie8,
linux-mtd, linux-kernel, Graham Moore, Dinh Nguyen
From: Graham Moore <grmoore@opensource.altera.com>
commit "3157d1ed2309 mtd: denali: remove unnecessary casts" introduced
an error by using a wrong bitmask.
A uint16_t cast was replaced with & 0xff, should be & 0xffff.
Signed-off-by: Graham Moore <grmoore@opensource.altera.com>
Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
---
drivers/mtd/nand/denali.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index b3b7ca1..5e397fb 100644
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -1041,7 +1041,7 @@ static void denali_setup_dma(struct denali_nand_info *denali, int op)
index_addr(denali, mode | ((addr >> 16) << 8), 0x2200);
/* 3. set memory low address bits 23:8 */
- index_addr(denali, mode | ((addr & 0xff) << 8), 0x2300);
+ index_addr(denali, mode | ((addr & 0xffff) << 8), 0x2300);
/* 4. interrupt when complete, burst len = 64 bytes */
index_addr(denali, mode | 0x14000, 0x2400);
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: denali: fix incorrect bitmask error in denali_setup_dma
2015-01-09 15:32 [PATCH] mtd: denali: fix incorrect bitmask error in denali_setup_dma dinguyen
@ 2015-01-13 10:33 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2015-01-13 10:33 UTC (permalink / raw)
To: dinguyen
Cc: dwmw2, dinh.linux, yamada.m, josh, shijie8, linux-mtd,
linux-kernel, Graham Moore
On Fri, Jan 09, 2015 at 09:32:35AM -0600, dinguyen@opensource.altera.com wrote:
> From: Graham Moore <grmoore@opensource.altera.com>
>
> commit "3157d1ed2309 mtd: denali: remove unnecessary casts" introduced
> an error by using a wrong bitmask.
>
> A uint16_t cast was replaced with & 0xff, should be & 0xffff.
>
> Signed-off-by: Graham Moore <grmoore@opensource.altera.com>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Pushed to l2-mtd.git. Thanks!
Brian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-13 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-09 15:32 [PATCH] mtd: denali: fix incorrect bitmask error in denali_setup_dma dinguyen
2015-01-13 10:33 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®