From: Philipp Zabel <p.zabel@pengutronix.de>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Lucas Stach <l.stach@pengutronix.de>,
Emil Renner Berthing <kernel@esmil.dk>,
Antoine Schweitzer-Chaput <antoine@schweitzer-chaput.fr>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpu: ipu-v3: wait_for_completion_timeout does not return negativ status
Date: Mon, 19 Jan 2015 09:09:11 +0100 [thread overview]
Message-ID: <1421654951.3758.2.camel@pengutronix.de> (raw)
In-Reply-To: <1421405282-8951-1-git-send-email-der.herr@hofr.at>
Hi Nicholas,
thank you for the patch.
Am Freitag, den 16.01.2015, 11:48 +0100 schrieb Nicholas Mc Guire:
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
>
> Patch is against 3.19.0-rc3 -next-20150109
>
> This patch was compiletested with imx_v6_v7_defconfig +
> CONFIG_RESET_CONTROLLER=y, CONFIG_IMX_IPUV3_CORE=m
>
> drivers/gpu/ipu-v3/ipu-dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu-dc.c
> index 2326c75..0ffa659 100644
> --- a/drivers/gpu/ipu-v3/ipu-dc.c
> +++ b/drivers/gpu/ipu-v3/ipu-dc.c
> @@ -282,7 +282,7 @@ void ipu_dc_disable_channel(struct ipu_dc *dc)
> enable_irq(irq);
> ret = wait_for_completion_timeout(&priv->comp, msecs_to_jiffies(50));
> disable_irq(irq);
> - if (ret <= 0) {
> + if (ret == 0) {
In addition to this, I think ret should be changed to unsigned long.
regards
Philipp
prev parent reply other threads:[~2015-01-19 8:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 10:48 Nicholas Mc Guire
2015-01-19 8:09 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421654951.3758.2.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=antoine@schweitzer-chaput.fr \
--cc=der.herr@hofr.at \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@esmil.dk \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®