* [PATCH] gpu: ipu-v3: wait_for_completion_timeout does not return negativ status
@ 2015-01-16 10:48 Nicholas Mc Guire
2015-01-19 8:09 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2015-01-16 10:48 UTC (permalink / raw)
To: Philipp Zabel
Cc: Greg Kroah-Hartman, Russell King, Lucas Stach,
Emil Renner Berthing, Antoine Schweitzer-Chaput, linux-kernel,
Nicholas Mc Guire
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
Patch is against 3.19.0-rc3 -next-20150109
This patch was compiletested with imx_v6_v7_defconfig +
CONFIG_RESET_CONTROLLER=y, CONFIG_IMX_IPUV3_CORE=m
drivers/gpu/ipu-v3/ipu-dc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu-dc.c
index 2326c75..0ffa659 100644
--- a/drivers/gpu/ipu-v3/ipu-dc.c
+++ b/drivers/gpu/ipu-v3/ipu-dc.c
@@ -282,7 +282,7 @@ void ipu_dc_disable_channel(struct ipu_dc *dc)
enable_irq(irq);
ret = wait_for_completion_timeout(&priv->comp, msecs_to_jiffies(50));
disable_irq(irq);
- if (ret <= 0) {
+ if (ret == 0) {
dev_warn(priv->dev, "DC stop timeout after 50 ms\n");
val = readl(dc->base + DC_WR_CH_CONF);
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] gpu: ipu-v3: wait_for_completion_timeout does not return negativ status
2015-01-16 10:48 [PATCH] gpu: ipu-v3: wait_for_completion_timeout does not return negativ status Nicholas Mc Guire
@ 2015-01-19 8:09 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2015-01-19 8:09 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Greg Kroah-Hartman, Russell King, Lucas Stach,
Emil Renner Berthing, Antoine Schweitzer-Chaput, linux-kernel
Hi Nicholas,
thank you for the patch.
Am Freitag, den 16.01.2015, 11:48 +0100 schrieb Nicholas Mc Guire:
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
>
> Patch is against 3.19.0-rc3 -next-20150109
>
> This patch was compiletested with imx_v6_v7_defconfig +
> CONFIG_RESET_CONTROLLER=y, CONFIG_IMX_IPUV3_CORE=m
>
> drivers/gpu/ipu-v3/ipu-dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu-dc.c
> index 2326c75..0ffa659 100644
> --- a/drivers/gpu/ipu-v3/ipu-dc.c
> +++ b/drivers/gpu/ipu-v3/ipu-dc.c
> @@ -282,7 +282,7 @@ void ipu_dc_disable_channel(struct ipu_dc *dc)
> enable_irq(irq);
> ret = wait_for_completion_timeout(&priv->comp, msecs_to_jiffies(50));
> disable_irq(irq);
> - if (ret <= 0) {
> + if (ret == 0) {
In addition to this, I think ret should be changed to unsigned long.
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-19 8:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-16 10:48 [PATCH] gpu: ipu-v3: wait_for_completion_timeout does not return negativ status Nicholas Mc Guire
2015-01-19 8:09 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®