From: Fabian Frederick <fabf@skynet.be>
To: linux-kernel@vger.kernel.org
Cc: Jan Kara <jack@suse.cz>, Alexander Viro <viro@zeniv.linux.org.uk>,
Fabian Frederick <fabf@skynet.be>
Subject: [RFC 1/2] FS: mount_bdev from vfs instead of filesystem specific mount function.
Date: Mon, 19 Jan 2015 21:47:20 +0100 [thread overview]
Message-ID: <1421700440-15128-1-git-send-email-fabf@skynet.be> (raw)
Currently, a lot of filesystem mounting functions feature in
file_system_type only to be called from vfs mount_fs and call mount_bdev.
This patch adds fill_super function to that structure and lets vfs
call mount_bdev when no mount function is declared.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/super.c | 6 +++++-
include/linux/fs.h | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/fs/super.c b/fs/super.c
index a89d625..7c37355 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1112,7 +1112,11 @@ mount_fs(struct file_system_type *type, int flags, const char *name, void *data)
goto out_free_secdata;
}
- root = type->mount(type, flags, name, data);
+ if (type->mount)
+ root = type->mount(type, flags, name, data);
+ else
+ root = mount_bdev(type, flags, name, data, type->fill_super);
+
if (IS_ERR(root)) {
error = PTR_ERR(root);
goto out_free_secdata;
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 0bd9669..3e19349 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1846,8 +1846,10 @@ struct file_system_type {
#define FS_USERNS_MOUNT 8 /* Can be mounted by userns root */
#define FS_USERNS_DEV_MOUNT 16 /* A userns mount does not imply MNT_NODEV */
#define FS_RENAME_DOES_D_MOVE 32768 /* FS will handle d_move() during rename() internally. */
+ int (*fill_super)(struct super_block *, void *, int);
struct dentry *(*mount) (struct file_system_type *, int,
const char *, void *);
+
void (*kill_sb) (struct super_block *);
struct module *owner;
struct file_system_type * next;
--
1.9.3
next reply other threads:[~2015-01-19 20:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 20:47 Fabian Frederick [this message]
2015-01-19 21:10 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421700440-15128-1-git-send-email-fabf@skynet.be \
--to=fabf@skynet.be \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®