From: Al Viro <viro@ZenIV.linux.org.uk>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: Re: [RFC 1/2] FS: mount_bdev from vfs instead of filesystem specific mount function.
Date: Mon, 19 Jan 2015 21:10:50 +0000 [thread overview]
Message-ID: <20150119211050.GG29656@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1421700440-15128-1-git-send-email-fabf@skynet.be>
On Mon, Jan 19, 2015 at 09:47:20PM +0100, Fabian Frederick wrote:
> Currently, a lot of filesystem mounting functions feature in
> file_system_type only to be called from vfs mount_fs and call mount_bdev.
>
> This patch adds fill_super function to that structure and lets vfs
> call mount_bdev when no mount function is declared.
NAK. First of all, quite a few of them are _not_ mount_bdev() users.
What's more, you are trading about 4 lines per filesystem (two of them
being { and }) for a layering violation.
No point whatsoever. fill_super() is no more a method than e.g. get_block().
prev parent reply other threads:[~2015-01-19 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 20:47 Fabian Frederick
2015-01-19 21:10 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119211050.GG29656@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=fabf@skynet.be \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome