From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: <agross@codeaurora.org>, <linux-kernel@vger.kernel.org>,
<patches@opensource.wolfsonmicro.com>,
<linux-arm-msm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 8/9] regulator: Drop now unused get_optimum_mode
Date: Tue, 27 Jan 2015 18:46:38 -0800 [thread overview]
Message-ID: <1422413199-17273-9-git-send-email-bjorn.andersson@sonymobile.com> (raw)
In-Reply-To: <1422413199-17273-1-git-send-email-bjorn.andersson@sonymobile.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---
drivers/regulator/core.c | 40 ++++++++--------------------------------
include/linux/regulator/driver.h | 5 -----
2 files changed, 8 insertions(+), 37 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 2a53515..cfab6fc 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -662,7 +662,6 @@ static int drms_uA_update(struct regulator_dev *rdev)
{
struct regulator *sibling;
int current_uA = 0, output_uV, input_uV, err;
- unsigned int mode;
/*
* first check to see if we can set modes at all, otherwise just
@@ -672,14 +671,9 @@ static int drms_uA_update(struct regulator_dev *rdev)
if (err < 0)
return 0;
- if (!rdev->desc->ops->get_optimum_mode &&
- !rdev->desc->ops->set_optimum_mode)
+ if (!rdev->desc->ops->set_optimum_mode)
return 0;
- if (!rdev->desc->ops->set_mode &&
- !rdev->desc->ops->set_optimum_mode)
- return -EINVAL;
-
/* get output voltage */
output_uV = _regulator_get_voltage(rdev);
if (output_uV <= 0) {
@@ -702,31 +696,13 @@ static int drms_uA_update(struct regulator_dev *rdev)
list_for_each_entry(sibling, &rdev->consumer_list, list)
current_uA += sibling->uA_load;
- if (rdev->desc->ops->set_optimum_mode) {
- /* set the optimum mode for our new total regulator load */
- err = rdev->desc->ops->set_optimum_mode(rdev,
- input_uV, output_uV,
- current_uA);
- if (err < 0)
- rdev_err(rdev, "failed to set optimum mode @ %d uA %d -> %d uV\n",
- current_uA, input_uV, output_uV);
- } else {
- /* now get the optimum mode for our new total regulator load */
- mode = rdev->desc->ops->get_optimum_mode(rdev, input_uV,
- output_uV, current_uA);
-
- /* check the new mode is allowed */
- err = regulator_mode_constrain(rdev, &mode);
- if (err < 0) {
- rdev_err(rdev, "failed to get optimum mode @ %d uA %d -> %d uV\n",
- current_uA, input_uV, output_uV);
- return err;
- }
-
- err = rdev->desc->ops->set_mode(rdev, mode);
- if (err < 0)
- rdev_err(rdev, "failed to set optimum mode %x\n", mode);
- }
+ /* set the optimum mode for our new total regulator load */
+ err = rdev->desc->ops->set_optimum_mode(rdev,
+ input_uV, output_uV,
+ current_uA);
+ if (err < 0)
+ rdev_err(rdev, "failed to set optimum mode @ %d uA %d -> %d uV\n",
+ current_uA, input_uV, output_uV);
return err;
}
diff --git a/include/linux/regulator/driver.h b/include/linux/regulator/driver.h
index 837addb..f472cb5 100644
--- a/include/linux/regulator/driver.h
+++ b/include/linux/regulator/driver.h
@@ -95,8 +95,6 @@ struct regulator_linear_range {
* @get_mode: Get the configured operating mode for the regulator.
* @get_status: Return actual (not as-configured) status of regulator, as a
* REGULATOR_STATUS value (or negative errno)
- * @get_optimum_mode: Get the most efficient operating mode for the regulator
- * when running with the specified parameters.
* @set_optimum_mode: Set the most efficient operating mode for the regulator
* when running with the specified parameters.
*
@@ -165,9 +163,6 @@ struct regulator_ops {
*/
int (*get_status)(struct regulator_dev *);
- /* get most efficient regulator operating mode for load */
- unsigned int (*get_optimum_mode) (struct regulator_dev *, int input_uV,
- int output_uV, int load_uA);
/* set most efficient regulator operating mode for load */
int (*set_optimum_mode)(struct regulator_dev *, int input_uV,
int output_uV, int load_uA);
--
1.9.1
next prev parent reply other threads:[~2015-01-28 2:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 2:46 [PATCH 0/9] Simplify regulator_set_optimum_mode Bjorn Andersson
2015-01-28 2:46 ` [PATCH 1/9] regulator: core: Consolidate drms update handling Bjorn Andersson
2015-01-28 19:52 ` Mark Brown
2015-01-28 2:46 ` [PATCH 2/9] regulator: core: Introduce set_optimum_mode op Bjorn Andersson
2015-01-28 19:52 ` Mark Brown
2015-01-30 0:07 ` Bjorn Andersson
2015-01-30 12:27 ` Mark Brown
2015-02-09 22:08 ` Bjorn Andersson
2015-02-10 7:08 ` Mark Brown
2015-02-05 22:16 ` Bjorn Andersson
2015-02-06 11:46 ` Mark Brown
2015-01-28 2:46 ` [PATCH 3/9] regulator: ab8500: move to set_optimum_mode Bjorn Andersson
2015-01-28 19:56 ` Mark Brown
2015-01-28 2:46 ` [PATCH 4/9] regulator: wm831x-ldo: " Bjorn Andersson
2015-01-28 2:46 ` [PATCH 5/9] regulator: wm8350: " Bjorn Andersson
2015-01-28 2:46 ` [PATCH 6/9] regulator: hi6421: " Bjorn Andersson
2015-01-28 2:46 ` [PATCH 7/9] regulator: wm8400: " Bjorn Andersson
2015-01-28 2:46 ` Bjorn Andersson [this message]
2015-01-28 2:46 ` [PATCH 9/9] regulator: qcom-rpm: Implement set_optimum_mode Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422413199-17273-9-git-send-email-bjorn.andersson@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=agross@codeaurora.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®