From: David Woodhouse <dwmw2@infradead.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: jffs2: Remove utf8 from printk string
Date: Fri, 06 Feb 2015 14:27:40 +0000 [thread overview]
Message-ID: <1423232860.26461.93.camel@infradead.org> (raw)
In-Reply-To: <1423232343-26438-1-git-send-email-linux@rasmusvillemoes.dk>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On Fri, 2015-02-06 at 15:19 +0100, Rasmus Villemoes wrote:
> Any non-ascii characters are escaped before being show to user-space,
> so this shows up as
>
> jffs2: version 2.2. (NAND) \xffffffc2\xffffffa9\xffffffa9 2001-2006
> Red Hat, Inc.
>
> (I have no idea why the second byte is repeated.) Replace with a
> widely used ascii replacement.
Nah. Fix the bug, don't apply a crappy workaround. This is the 21st
century.
> Actually, I don't see the value in printing a copyright notice to the
> kernel log, especially since it's out-of-sync with the one at the top
> of the file.
Agreed. Removing it would be better than the crappy workaround. But
let's use it as a test case to fix the *real* bug first.
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5745 bytes --]
prev parent reply other threads:[~2015-02-06 14:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 14:19 Rasmus Villemoes
2015-02-06 14:27 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423232860.26461.93.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®