[PATCH] fs: jffs2: Remove utf8 from printk string

[PATCH] fs: jffs2: Remove utf8 from printk string

[Rasmus Villemoes]

Any non-ascii characters are escaped before being show to user-space,
so this shows up as

jffs2: version 2.2. (NAND) \xffffffc2\xffffffa9\xffffffa9 2001-2006 Red Hat, Inc.

(I have no idea why the second byte is repeated.) Replace with a
widely used ascii replacement.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
Actually, I don't see the value in printing a copyright notice to the
kernel log, especially since it's out-of-sync with the one at the top
of the file.

 fs/jffs2/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
index 0918f0e2e266..471b674b6f8a 100644
--- a/fs/jffs2/super.c
+++ b/fs/jffs2/super.c
@@ -382,7 +382,7 @@ static int __init init_jffs2_fs(void)
 #ifdef CONFIG_JFFS2_SUMMARY
 	       " (SUMMARY) "
 #endif
-	       " © 2001-2006 Red Hat, Inc.\n");
+	       " (c) 2001-2006 Red Hat, Inc.\n");
 
 	jffs2_inode_cachep = kmem_cache_create("jffs2_i",
 					     sizeof(struct jffs2_inode_info),
-- 
2.1.3

Re: [PATCH] fs: jffs2: Remove utf8 from printk string

[David Woodhouse]

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

On Fri, 2015-02-06 at 15:19 +0100, Rasmus Villemoes wrote:
> Any non-ascii characters are escaped before being show to user-space,
> so this shows up as
> 
> jffs2: version 2.2. (NAND) \xffffffc2\xffffffa9\xffffffa9 2001-2006
> Red Hat, Inc.
> 
> (I have no idea why the second byte is repeated.) Replace with a
> widely used ascii replacement.

Nah. Fix the bug, don't apply a crappy workaround. This is the 21st
century.

> Actually, I don't see the value in printing a copyright notice to the
> kernel log, especially since it's out-of-sync with the one at the top
> of the file.

Agreed. Removing it would be better than the crappy workaround. But
let's use it as a test case to fix the *real* bug first.

-- 
dwmw2

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5745 bytes --]