From: Xunlei Pang <pang.xunlei@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Juri Lelli <juri.lelli@gmail.com>,
Xunlei Pang <pang.xunlei@linaro.org>
Subject: [PATCH v3 2/2] sched/rt: Add check_preempt_equal_prio() logic in pick_next_task_rt()
Date: Sun, 8 Feb 2015 23:51:26 +0800 [thread overview]
Message-ID: <1423410686-1928-2-git-send-email-pang.xunlei@linaro.org> (raw)
In-Reply-To: <1423410686-1928-1-git-send-email-pang.xunlei@linaro.org>
check_preempt_curr() doesn't call sched_class::check_preempt_curr
when the class of current is a higher level. So if there is a DL
task running when doing this for RT, check_preempt_equal_prio()
will definitely miss, which may result in some response latency
for this RT task if it is pinned and there're some same-priority
migratable rt tasks already queued.
We should do the similar thing in select_task_rq_rt() when first
picking rt tasks after running out of DL tasks.
This patch tackles the issue by peeking the next rt task(RT1), and
if find RT1 migratable, just requeue it to the tail of the rq using
requeue_task_rt(rq, p, 0). In this way:
- If there do have another rt task(RT2) with the same priority as
RT1, RT2 will finally be picked as the running task. While RT1
will be pushed onto another cpu via RT1's post_schedule(), as
RT1 is migratable. The difference from check_preempt_equal_prio()
here is that we just don't care whether RT2 is migratable.
- Otherwise, if there's no rt task with the same priority as RT1,
RT1 will still be picked as the running task after the requeuing.
Signed-off-by: Xunlei Pang <pang.xunlei@linaro.org>
---
kernel/sched/rt.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 04c58b7..26114f5 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1482,6 +1482,22 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev)
put_prev_task(rq, prev);
+#ifdef CONFIG_SMP
+ /*
+ * If there's a running higher class task, check_preempt_curr()
+ * doesn't invoke check_preempt_equal_prio() for rt tasks, so
+ * we can do the similar thing here.
+ */
+ if (rq->rt.rt_nr_total > 1 &&
+ (prev->sched_class == &dl_sched_class ||
+ prev->sched_class == &stop_sched_class)) {
+ p = peek_next_task_rt(rq);
+ if (p->nr_cpus_allowed != 1 &&
+ cpupri_find(&rq->rd->cpupri, p, NULL))
+ requeue_task_rt(rq, p, 0);
+ }
+#endif
+
p = _pick_next_task_rt(rq);
/* The running task is never eligible for pushing */
--
1.9.1
next prev parent reply other threads:[~2015-02-08 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-08 15:51 [PATCH v3 1/2] sched/rt: Check to push the task when changing its affinity Xunlei Pang
2015-02-08 15:51 ` Xunlei Pang [this message]
2015-02-13 0:04 ` [PATCH v3 2/2] sched/rt: Add check_preempt_equal_prio() logic in pick_next_task_rt() Steven Rostedt
2015-02-13 3:55 ` Xunlei Pang
2015-02-13 4:40 ` Xunlei Pang
2015-02-13 5:05 ` Steven Rostedt
[not found] ` <OF7733F37C.3800A165-ON48257DED.000809A5-48257DED.00100D03@zte.com.cn>
2015-02-15 4:23 ` Steven Rostedt
2015-02-12 23:31 ` [PATCH v3 1/2] sched/rt: Check to push the task when changing its affinity Steven Rostedt
2015-02-13 3:38 ` Xunlei Pang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423410686-1928-2-git-send-email-pang.xunlei@linaro.org \
--to=pang.xunlei@linaro.org \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®