From: Steven Rostedt <rostedt@goodmis.org>
To: pang.xunlei@zte.com.cn
Cc: Juri Lelli <juri.lelli@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-kernel-owner@vger.kernel.org,
Xunlei Pang <pang.xunlei@linaro.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v3 2/2] sched/rt: Add check_preempt_equal_prio() logic in pick_next_task_rt()
Date: Sat, 14 Feb 2015 23:23:50 -0500 [thread overview]
Message-ID: <20150214232350.42b8eeae@grimm.local.home> (raw)
In-Reply-To: <OF7733F37C.3800A165-ON48257DED.000809A5-48257DED.00100D03@zte.com.cn>
On Sun, 15 Feb 2015 10:54:25 +0800
pang.xunlei@zte.com.cn wrote:
> I think this can also happen for check_preempt_equal_prio():
> When RT1(current task) gets preempted by RT2, if there is a
> migratable RT3 with same prio, RT3 will be pushed away instead
> of RT1 afterwards, because RT1 will be enqueued to the tail of
> the pushable list via succeeding put_prev_task_rt() triggered
> by resched.
>
> There seems some trouble involved in rt equal prio cases.
Hmm, you may be right, and that should be fixed. If a task is running
and gets preempted by a higher priority task (or even of same priority
for migrating), then it should stay at the front of the queue to be
migrated. It should only be placed after other FIFO tasks of the same
priority if that task calls schedule() directly (not preempted).
SMP always cracks a few rotten eggs in the RT omelet.
-- Steve
next prev parent reply other threads:[~2015-02-15 4:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-08 15:51 [PATCH v3 1/2] sched/rt: Check to push the task when changing its affinity Xunlei Pang
2015-02-08 15:51 ` [PATCH v3 2/2] sched/rt: Add check_preempt_equal_prio() logic in pick_next_task_rt() Xunlei Pang
2015-02-13 0:04 ` Steven Rostedt
2015-02-13 3:55 ` Xunlei Pang
2015-02-13 4:40 ` Xunlei Pang
2015-02-13 5:05 ` Steven Rostedt
[not found] ` <OF7733F37C.3800A165-ON48257DED.000809A5-48257DED.00100D03@zte.com.cn>
2015-02-15 4:23 ` Steven Rostedt [this message]
2015-02-12 23:31 ` [PATCH v3 1/2] sched/rt: Check to push the task when changing its affinity Steven Rostedt
2015-02-13 3:38 ` Xunlei Pang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150214232350.42b8eeae@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pang.xunlei@linaro.org \
--cc=pang.xunlei@zte.com.cn \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®