mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
	gregkh@linuxfoundation.org, sudipm.mukherjee@gmail.com,
	devel@driverdev.osuosl.org, HPDD-discuss@ml01.01.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration
Date: Mon, 09 Feb 2015 08:29:29 -0800	[thread overview]
Message-ID: <1423499369.2933.18.camel@perches.com> (raw)
In-Reply-To: <1423498556-18703-1-git-send-email-md.jamalmohiuddin@gmail.com>

On Mon, 2015-02-09 at 21:45 +0530, Mohammad Jamal wrote:
> This patch adds a static keyword to variable portal_rotor to
> suppress the sparse warning of static declaration

Do please compile the subsystem before sending patches.

> diff --git a/drivers/staging/lustre/lnet/lnet/lib-ptl.c b/drivers/staging/lustre/lnet/lnet/lib-ptl.c
[]
> @@ -39,7 +39,7 @@
>  #include "../../include/linux/lnet/lib-lnet.h"
>  
>  /* NB: add /proc interfaces in upcoming patches */
> -int	portal_rotor	= LNET_PTL_ROTOR_HASH_RT;
> +static int	portal_rotor	= LNET_PTL_ROTOR_HASH_RT;
>  module_param(portal_rotor, int, 0644);
>  MODULE_PARM_DESC(portal_rotor, "redirect PUTs to different cpu-partitions");

$ git grep -w portal_rotor
...
drivers/staging/lustre/lnet/lnet/router_proc.c:extern int portal_rotor;




      reply	other threads:[~2015-02-09 16:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 16:15 Mohammad Jamal
2015-02-09 16:29 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423499369.2933.18.camel@perches.com \
    --to=joe@perches.com \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=md.jamalmohiuddin@gmail.com \
    --cc=oleg.drokin@intel.com \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®