* [PATCH 1/3] fs/fat: remove unnecessary defintion
@ 2015-02-18 19:10 Alexander Kuleshov
2015-02-18 19:11 ` Alexander Kuleshov
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kuleshov @ 2015-02-18 19:10 UTC (permalink / raw)
To: OGAWA Hirofumi; +Cc: linux-kernel, Alexander Kuleshov
'*sb' never used, so let's remote it and pass inode->i_sb directly to
the MSDOS_SB.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
fs/fat/inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 7b41a2d..e140e62 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1280,8 +1280,7 @@ out:
static int fat_read_root(struct inode *inode)
{
- struct super_block *sb = inode->i_sb;
- struct msdos_sb_info *sbi = MSDOS_SB(sb);
+ struct msdos_sb_info *sbi = MSDOS_SB(inode->i_sb);
int error;
MSDOS_I(inode)->i_pos = MSDOS_ROOT_INO;
--
2.3.0.401.g57a267c.dirty
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/3] fs/fat: remove unnecessary defintion
2015-02-18 19:10 [PATCH 1/3] fs/fat: remove unnecessary defintion Alexander Kuleshov
@ 2015-02-18 19:11 ` Alexander Kuleshov
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Kuleshov @ 2015-02-18 19:11 UTC (permalink / raw)
To: OGAWA Hirofumi; +Cc: linux-kernel, Alexander Kuleshov
Sorry for noise. Sent wrong patch.
2015-02-19 1:10 GMT+06:00 Alexander Kuleshov <kuleshovmail@gmail.com>:
> '*sb' never used, so let's remote it and pass inode->i_sb directly to
> the MSDOS_SB.
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> fs/fat/inode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 7b41a2d..e140e62 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -1280,8 +1280,7 @@ out:
>
> static int fat_read_root(struct inode *inode)
> {
> - struct super_block *sb = inode->i_sb;
> - struct msdos_sb_info *sbi = MSDOS_SB(sb);
> + struct msdos_sb_info *sbi = MSDOS_SB(inode->i_sb);
> int error;
>
> MSDOS_I(inode)->i_pos = MSDOS_ROOT_INO;
> --
> 2.3.0.401.g57a267c.dirty
>
--
_________________________
0xAX
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 0/3] fs/fat: minor cleanup
@ 2015-02-17 19:21 Alexander Kuleshov
2015-02-17 19:22 ` [PATCH 1/3] fs/fat: remove unnecessary defintion Alexander Kuleshov
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kuleshov @ 2015-02-17 19:21 UTC (permalink / raw)
To: hirofumi; +Cc: linux-kernel
Hello,
this patchset provides a couple of minor cleanup.
Alexander Kuleshov (3):
fs/fat: remove unnecessary super_block *sb defintion
fs/fat: use MSDOS_SB to get msdos superblock
fs/fat: remove unnecessary includes
fs/fat/cache.c | 2 --
fs/fat/dir.c | 4 ----
fs/fat/fat.h | 3 ---
fs/fat/fatent.c | 3 ---
fs/fat/file.c | 4 ----
fs/fat/inode.c | 15 ++-------------
fs/fat/misc.c | 4 ----
fs/fat/namei_msdos.c | 2 --
fs/fat/namei_vfat.c | 2 --
fs/fat/nfs.c | 1 -
10 files changed, 2 insertions(+), 38 deletions(-)
--
2.3.0.401.g57a267c.dirty
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/3] fs/fat: remove unnecessary defintion
2015-02-17 19:21 [PATCH 0/3] fs/fat: minor cleanup Alexander Kuleshov
@ 2015-02-17 19:22 ` Alexander Kuleshov
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Kuleshov @ 2015-02-17 19:22 UTC (permalink / raw)
To: hirofumi; +Cc: linux-kernel, Alexander Kuleshov
'*sb' never used, so let's remote it and pass inode->i_sb directly to
the MSDOS_SB.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
fs/fat/inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 7b41a2d..e140e62 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1280,8 +1280,7 @@ out:
static int fat_read_root(struct inode *inode)
{
- struct super_block *sb = inode->i_sb;
- struct msdos_sb_info *sbi = MSDOS_SB(sb);
+ struct msdos_sb_info *sbi = MSDOS_SB(inode->i_sb);
int error;
MSDOS_I(inode)->i_pos = MSDOS_ROOT_INO;
--
2.3.0.401.g57a267c.dirty
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-18 19:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-18 19:10 [PATCH 1/3] fs/fat: remove unnecessary defintion Alexander Kuleshov
2015-02-18 19:11 ` Alexander Kuleshov
-- strict thread matches above, loose matches on Subject: below --
2015-02-17 19:21 [PATCH 0/3] fs/fat: minor cleanup Alexander Kuleshov
2015-02-17 19:22 ` [PATCH 1/3] fs/fat: remove unnecessary defintion Alexander Kuleshov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®