mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: brian@peloton-tech.com
To: mingo@redhat.com, peterz@infradead.org
Cc: austin@peloton-tech.com, linux-kernel@vger.kernel.org,
	brian@peloton-tech.com
Subject: [PATCH] sched: fix RLIMIT_RTTIME when PI-boosting to RT
Date: Wed, 18 Feb 2015 16:23:56 -0800	[thread overview]
Message-ID: <1424305436-6716-1-git-send-email-brian@peloton-tech.com> (raw)

From: Brian Silverman <brian@peloton-tech.com>

When non-realtime tasks get priority-inheritance boosted to a realtime
scheduling class, RLIMIT_RTTIME starts to apply to them. However, the
counter used for checking this (the same one used for SCHED_RR
timeslices) was not getting reset. This meant that tasks running with a
non-realtime scheduling class which are repeatedly boosted to a realtime
one, but never block while they are running realtime, eventually hit the
timeout without ever running for a time over the limit. This patch
resets the realtime timeslice counter when un-PI-boosting from an RT to
a non-RT scheduling class.

I have some test code with two threads and a shared PTHREAD_PRIO_INHERIT
mutex which induces priority boosting and spins while boosted that gets
killed by a SIGXCPU on non-fixed kernels but doesn't with this patch
applied. It happens much faster with a CONFIG_PREEMPT_RT kernel, and
does happen eventually with PREEMPT_VOLUNTARY kernels.

Signed-off-by: Brian Silverman <brian@peloton-tech.com>
---
I am not subscribed to the list so please CC me on any responses.

 kernel/sched/core.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 87b9814..16ad0ed 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3192,6 +3192,8 @@ void rt_mutex_setprio(struct task_struct *p, int prio)
 	} else {
 		if (dl_prio(oldprio))
 			p->dl.dl_boosted = 0;
+		if (rt_prio(oldprio))
+			p->rt.timeout = 0;
 		p->sched_class = &fair_sched_class;
 	}
 
-- 
1.7.10.4


             reply	other threads:[~2015-02-19  0:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19  0:23 brian [this message]
2015-02-19  0:23 ` Brian Silverman
2015-03-10  5:42   ` Ingo Molnar
2015-03-05 17:10 ` Austin Schuh
2015-03-09 17:34   ` Sebastian Andrzej Siewior
2015-03-09 23:29     ` Brian Silverman
2015-03-23 12:24 ` [tip:sched/core] sched: Fix " tip-bot for Brian Silverman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424305436-6716-1-git-send-email-brian@peloton-tech.com \
    --to=brian@peloton-tech.com \
    --cc=austin@peloton-tech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®