From: Ingo Molnar <mingo@kernel.org>
To: Brian Silverman <brian@peloton-tech.com>
Cc: mingo <mingo@redhat.com>, peterz <peterz@infradead.org>,
Austin Schuh <austin@peloton-tech.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH] sched: fix RLIMIT_RTTIME when PI-boosting to RT
Date: Tue, 10 Mar 2015 06:42:52 +0100 [thread overview]
Message-ID: <20150310054252.GA11485@gmail.com> (raw)
In-Reply-To: <CAGt3f4=HmWU0ng=PNNyzA_5-FefMmWg-pOKzSL3Sc0ow=xHVug@mail.gmail.com>
* Brian Silverman <brian@peloton-tech.com> wrote:
> Here's my test code. Compile with `gcc -pthread -lrt test_pi.c`. It
> requires permission to set a realtime scheduling policy of 2 when
> running.
Mind sending a patch that sticks this testcase into
tools/testing/selftests/sched/ or so, with the new 'sched' directory
and new Makefile to be created by you as well?
I've reformatted the testcase below, to kernel coding style. Note that
I added a minimal license notification, you might want to add your
copyright.
Thanks,
Ingo
==========================>
/*
* RLIMIT_RTTIME test code. Compile with:
*
* gcc -pthread -lrt test_pi.c
*
* It requires permission to set a realtime scheduling policy of 2 when running.
*
* License: GPLv2
*/
#define _GNU_SOURCE
#include <pthread.h>
#include <unistd.h>
#include <stdio.h>
#include <time.h>
#include <sched.h>
#include <assert.h>
#include <sys/resource.h>
#include <string.h>
#include <signal.h>
#include <stdlib.h>
static const struct timespec kSleepTime = { 0, 10000 };
static pthread_mutex_t mutex;
extern void nop()
{
}
void *nonrealtime(void *ignored_param)
{
while (1) {
assert(pthread_mutex_lock(&mutex) == 0);
assert(pthread_mutex_unlock(&mutex) == 0);
assert(clock_nanosleep(CLOCK_MONOTONIC, 0, &kSleepTime, NULL) == 0);
}
}
void *realtime(void *ignored_param)
{
struct sched_param param;
memset(¶m, 0, sizeof(param));
param.sched_priority = 2;
assert(sched_setscheduler(0, SCHED_FIFO, ¶m) == 0);
while (1) {
assert(pthread_mutex_lock(&mutex) == 0);
assert(clock_nanosleep(CLOCK_MONOTONIC, 0, &kSleepTime, NULL) == 0);
assert(pthread_mutex_unlock(&mutex) == 0);
}
}
void signal_handler(int number)
{
printf("got signal %d, SIGXCPU=%d\n", number, SIGXCPU);
exit(0);
}
int main()
{
struct sigaction action;
memset(&action, 0, sizeof(action));
action.sa_handler = signal_handler;
assert(sigaction(SIGXCPU, &action, NULL) == 0);
struct rlimit rlim;
rlim.rlim_cur = 500;
rlim.rlim_max = 5000;
assert(prlimit(0, RLIMIT_RTTIME, &rlim, NULL) == 0);
pthread_mutexattr_t mutexattr;
assert(pthread_mutexattr_init(&mutexattr) == 0);
assert(pthread_mutexattr_setprotocol(&mutexattr, PTHREAD_PRIO_INHERIT) == 0);
assert(pthread_mutex_init(&mutex, &mutexattr) == 0);
assert(pthread_mutexattr_destroy(&mutexattr) == 0);
pthread_t nrt, rt;
assert(pthread_create(&nrt, NULL, nonrealtime, NULL) == 0);
assert(pthread_create(&rt, NULL, realtime, NULL) == 0);
assert(pthread_join(nrt, NULL) == 0);
assert(pthread_join(rt, NULL) == 0);
return 0;
}
next prev parent reply other threads:[~2015-03-10 5:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 0:23 brian
2015-02-19 0:23 ` Brian Silverman
2015-03-10 5:42 ` Ingo Molnar [this message]
2015-03-05 17:10 ` Austin Schuh
2015-03-09 17:34 ` Sebastian Andrzej Siewior
2015-03-09 23:29 ` Brian Silverman
2015-03-23 12:24 ` [tip:sched/core] sched: Fix " tip-bot for Brian Silverman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310054252.GA11485@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=austin@peloton-tech.com \
--cc=brian@peloton-tech.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome