mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Felipe Balbi <balbi@ti.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH] usb: isp1760: fix peripheral/device controller chip id
Date: Tue, 24 Feb 2015 17:53:42 +0000	[thread overview]
Message-ID: <1424800422-25332-1-git-send-email-sudeep.holla@arm.com> (raw)

As per the ISP1761 data sheet, the DcChipID register represents
the hardware version number (0015h) and the chip ID (8210h) for the
Peripheral Controller.

This patch fixes the chip ID value used to verify the controller.

Cc: Felipe Balbi <balbi@ti.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/usb/isp1760/isp1760-udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Laurent,

I found that the chip ID is wrong when I tried testing OTG on vexpress
platforms. As per Section 10.8.2 DcChipID register in [1], it should be
0x00158210.

It's still not functional, I will follow up with the logs separately.

Regards,
Sudeep
[1] http://ridl.cfd.rit.edu/products/manuals/Altera/DE3_v.1.7_CDROM/Datasheet/USB/ISP1761.pdf#G2148521

diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1760-udc.c
index 9612d7990565..87a8dc044fce 100644
--- a/drivers/usb/isp1760/isp1760-udc.c
+++ b/drivers/usb/isp1760/isp1760-udc.c
@@ -1411,7 +1411,7 @@ static int isp1760_udc_init(struct isp1760_udc *udc)
 		return -ENODEV;
 	}
 
-	if (chipid != 0x00011582) {
+	if (chipid != 0x00158210) {
 		dev_err(udc->isp->dev, "udc: invalid chip ID 0x%08x\n", chipid);
 		return -ENODEV;
 	}
-- 
1.9.1


             reply	other threads:[~2015-02-24 17:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 17:53 Sudeep Holla [this message]
2015-02-25 22:27 ` Laurent Pinchart
2015-02-26 10:24   ` Sudeep Holla
2015-02-26 11:47 ` [PATCH v2] usb: isp1760: add " Sudeep Holla
2015-02-26 18:53   ` Laurent Pinchart
2015-03-04 15:56     ` Sudeep Holla
2015-03-04 16:11       ` Laurent Pinchart
2015-03-04 17:04         ` Sudeep Holla
2015-03-05 11:12           ` Laurent Pinchart
2015-03-09 15:49       ` Felipe Balbi
2015-03-09 15:58         ` Sudeep Holla
2015-03-09 16:13           ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424800422-25332-1-git-send-email-sudeep.holla@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®