From: Sudeep Holla <sudeep.holla@arm.com>
To: Felipe Balbi <balbi@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v2] usb: isp1760: add peripheral/device controller chip id
Date: Thu, 26 Feb 2015 11:47:57 +0000 [thread overview]
Message-ID: <1424951277-13375-1-git-send-email-sudeep.holla@arm.com> (raw)
In-Reply-To: <1424800422-25332-1-git-send-email-sudeep.holla@arm.com>
As per the SAF1761 data sheet[0], the DcChipID register represents
the hardware version number (0001h) and the chip ID (1582h) for the
Peripheral Controller.
However as per the ISP1761 data sheet[1], the DcChipID register
represents the hardware version number (0015h) and the chip ID (8210h)
for the Peripheral Controller.
This patch adds support for both the chip ID values.
[0] http://www.nxp.com/documents/data_sheet/SAF1761.pdf
[1] http://pdf.datasheetcatalog.com/datasheets2/74/742102_1.pdf
Cc: Felipe Balbi <balbi@ti.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/usb/isp1760/isp1760-udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Changes v1->v2:
- Updated to support both chip IDs: 0x00011582 and 0x00158210 instead of
just 0x00158210 as suggested by Laurent
diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1760-udc.c
index 9612d7990565..6d618b3fab07 100644
--- a/drivers/usb/isp1760/isp1760-udc.c
+++ b/drivers/usb/isp1760/isp1760-udc.c
@@ -1411,7 +1411,7 @@ static int isp1760_udc_init(struct isp1760_udc *udc)
return -ENODEV;
}
- if (chipid != 0x00011582) {
+ if (chipid != 0x00011582 && chipid != 0x00158210) {
dev_err(udc->isp->dev, "udc: invalid chip ID 0x%08x\n", chipid);
return -ENODEV;
}
--
1.9.1
next prev parent reply other threads:[~2015-02-26 11:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 17:53 [PATCH] usb: isp1760: fix " Sudeep Holla
2015-02-25 22:27 ` Laurent Pinchart
2015-02-26 10:24 ` Sudeep Holla
2015-02-26 11:47 ` Sudeep Holla [this message]
2015-02-26 18:53 ` [PATCH v2] usb: isp1760: add " Laurent Pinchart
2015-03-04 15:56 ` Sudeep Holla
2015-03-04 16:11 ` Laurent Pinchart
2015-03-04 17:04 ` Sudeep Holla
2015-03-05 11:12 ` Laurent Pinchart
2015-03-09 15:49 ` Felipe Balbi
2015-03-09 15:58 ` Sudeep Holla
2015-03-09 16:13 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424951277-13375-1-git-send-email-sudeep.holla@arm.com \
--to=sudeep.holla@arm.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®