From: Daniel Granat <d.granat@samsung.com>
To: Julia.Lawall@lip6.fr, cocci@systeme.lip6.fr,
linux-kernel@vger.kernel.org
Cc: Gilles.Muller@lip6.fr, nicolas.palix@imag.fr,
Daniel Granat <d.granat@samsung.com>
Subject: [PATCH] Add coccinelle script that makes sure that tables are NULL terminated
Date: Fri, 27 Feb 2015 14:21:53 +0100 [thread overview]
Message-ID: <1425043313-15844-1-git-send-email-d.granat@samsung.com> (raw)
Signed-off-by: Daniel Granat <d.granat@samsung.com>
---
scripts/coccinelle/misc/device_id_tables.cocci | 95 ++++++++++++++++++++++++++
1 file changed, 95 insertions(+)
create mode 100644 scripts/coccinelle/misc/device_id_tables.cocci
diff --git a/scripts/coccinelle/misc/device_id_tables.cocci b/scripts/coccinelle/misc/device_id_tables.cocci
new file mode 100644
index 0000000..5968984
--- /dev/null
+++ b/scripts/coccinelle/misc/device_id_tables.cocci
@@ -0,0 +1,95 @@
+/// Make sure '*_device_id$' tables are NULL terminated
+//
+// Keywords: device_id
+// Confidence: Medium
+// Options: --include-headers
+
+virtual org
+virtual report
+virtual patch
+
+@initialize:python@
+@@
+import re
+
+postfix = '_device_id$'
+prefix_list = ['platform', 'of', 'i2c']
+
+@r1 depends on patch || org || report@
+position p1;
+identifier var, arr;
+identifier struct_name;
+expression E;
+@@
+
+(
+struct struct_name arr[] = {
+ ...,
+ {
+ .var = E,
+ }
+ @p1
+};
+|
+struct struct_name arr[] = {
+ ...,
+ { ..., var, ... },
+ @p1
+};
+)
+
+@script:python depends on report@
+struct_name << r1.struct_name;
+p1 << r1.p1;
+arr << r1.arr;
+pattern;
+@@
+
+for i in prefix_list:
+ pattern = str(i)+postfix
+ if re.match(pattern, struct_name) != None:
+ print "\nCOCCI: \"%s\" matchs required pattern \"%s\"" % (struct_name, pattern)
+ msg = "\"%s\" is not NULL terminated at line %s" % (arr, p1[0].line)
+ coccilib.report.print_report(p1[0],msg)
+ break
+
+@script:python match depends on patch@
+struct_name << r1.struct_name;
+matched_name;
+pattern;
+@@
+
+coccinelle.matched_name = ''
+
+for i in prefix_list:
+ pattern = str(i)+postfix
+ if re.match(pattern, struct_name) != None:
+ coccinelle.matched_name = struct_name
+ break
+
+@r2 depends on patch@
+position r1.p1;
+identifier var, arr;
+identifier match.matched_name;
+expression E;
+@@
+
+(
+struct matched_name arr[] = {
+ ...,
+ {
+ .var = E,
+- }
+ @p1
++ },
++ {},
+};
+|
+struct matched_name arr[] = {
+ ...,
+ { ..., var, ... },
+ @p1
++ {},
+};
+)
+
--
1.9.1
next reply other threads:[~2015-02-27 13:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 13:21 Daniel Granat [this message]
2015-03-27 10:32 ` Daniel Granat
2015-04-22 11:08 ` Krzysztof Kozlowski
2015-04-22 11:16 ` Daniel Granat
2015-05-18 11:29 ` [PATCH v2] " Daniel Granat
2015-05-19 8:57 ` Julia Lawall
2015-05-19 11:58 ` [PATCH v3] Added tables i2c_device_id and platform_device_id for checking. Extend checking on tables containing structures which are initialized without specifying member name Daniel Granat
2015-05-25 20:19 ` Julia Lawall
2015-06-02 16:10 ` [PATCH v4] Added tables i2c_device_id and platform_device_id for Daniel Granat
2015-06-02 16:10 ` [PATCH v4] Added tables i2c_device_id and platform_device_id for checking. Extend checking on tables containing structures which are initialized without specifying member name Daniel Granat
2015-06-03 9:42 ` Julia Lawall
2015-06-23 11:02 ` [PATCH v5] Added tables (i2c/platform)_device_id " Daniel Granat
2015-06-23 11:50 ` Krzysztof Kozlowski
2015-06-23 12:25 ` Julia Lawall
2015-06-26 14:39 ` [PATCH v6] coccinelle: Improve checking for missing NULL terminators Daniel Granat
2015-10-23 15:31 ` Daniel Granat
2015-10-23 19:35 ` Julia Lawall
2015-10-26 21:46 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425043313-15844-1-git-send-email-d.granat@samsung.com \
--to=d.granat@samsung.com \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®