From: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
To: Daniel Granat <d.granat@samsung.com>,
Julia.Lawall@lip6.fr, cocci@systeme.lip6.fr,
linux-kernel@vger.kernel.org
Cc: Gilles.Muller@lip6.fr, nicolas.palix@imag.fr
Subject: Re: [PATCH] Add coccinelle script that makes sure that tables are NULL terminated
Date: Wed, 22 Apr 2015 20:08:20 +0900 [thread overview]
Message-ID: <55378124.2060908@gmail.com> (raw)
In-Reply-To: <1425043313-15844-1-git-send-email-d.granat@samsung.com>
W dniu 27.02.2015 o 22:21, Daniel Granat pisze:
> Signed-off-by: Daniel Granat <d.granat@samsung.com>
> ---
> scripts/coccinelle/misc/device_id_tables.cocci | 95 ++++++++++++++++++++++++++
> 1 file changed, 95 insertions(+)
> create mode 100644 scripts/coccinelle/misc/device_id_tables.cocci
I like the idea and I think it is useful.
Tested-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
However applying the patch gave some warnings:
Applying: Add coccinelle script that makes sure that tables are NULL terminated
/home/dev/linux/linux/.git/rebase-apply/patch:64: space before tab in indent.
coccilib.report.print_report(p1[0],msg)
/home/dev/linux/linux/.git/rebase-apply/patch:89: trailing whitespace.
struct matched_name arr[] = {
/home/dev/linux/linux/.git/rebase-apply/patch:99: trailing whitespace.
struct matched_name arr[] = {
/home/dev/linux/linux/.git/rebase-apply/patch:106: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-04-22 11:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 13:21 Daniel Granat
2015-03-27 10:32 ` Daniel Granat
2015-04-22 11:08 ` Krzysztof Kozlowski [this message]
2015-04-22 11:16 ` Daniel Granat
2015-05-18 11:29 ` [PATCH v2] " Daniel Granat
2015-05-19 8:57 ` Julia Lawall
2015-05-19 11:58 ` [PATCH v3] Added tables i2c_device_id and platform_device_id for checking. Extend checking on tables containing structures which are initialized without specifying member name Daniel Granat
2015-05-25 20:19 ` Julia Lawall
2015-06-02 16:10 ` [PATCH v4] Added tables i2c_device_id and platform_device_id for Daniel Granat
2015-06-02 16:10 ` [PATCH v4] Added tables i2c_device_id and platform_device_id for checking. Extend checking on tables containing structures which are initialized without specifying member name Daniel Granat
2015-06-03 9:42 ` Julia Lawall
2015-06-23 11:02 ` [PATCH v5] Added tables (i2c/platform)_device_id " Daniel Granat
2015-06-23 11:50 ` Krzysztof Kozlowski
2015-06-23 12:25 ` Julia Lawall
2015-06-26 14:39 ` [PATCH v6] coccinelle: Improve checking for missing NULL terminators Daniel Granat
2015-10-23 15:31 ` Daniel Granat
2015-10-23 19:35 ` Julia Lawall
2015-10-26 21:46 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55378124.2060908@gmail.com \
--to=k.kozlowski.k@gmail.com \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=d.granat@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome