mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
	vkuznets@redhat.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>, stable@vger.kernel.org
Subject: [PATCH RESEND 14/15] Drivers: hv: vmbus: Fix a bug in the error path in vmbus_open()
Date: Fri, 27 Feb 2015 11:26:04 -0800	[thread overview]
Message-ID: <1425065165-21823-14-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1425065165-21823-1-git-send-email-kys@microsoft.com>

Correctly rollback state if the failure occurs after we have handed over
the ownership of the buffer to the host.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: stable@vger.kernel.org
---
 drivers/hv/channel.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index f687995..bf0cf8f 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -137,7 +137,7 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size,
 			   GFP_KERNEL);
 	if (!open_info) {
 		err = -ENOMEM;
-		goto error0;
+		goto error_gpadl;
 	}
 
 	init_completion(&open_info->waitevent);
@@ -153,7 +153,7 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size,
 
 	if (userdatalen > MAX_USER_DEFINED_BYTES) {
 		err = -EINVAL;
-		goto error0;
+		goto error_gpadl;
 	}
 
 	if (userdatalen)
@@ -197,6 +197,9 @@ error1:
 	list_del(&open_info->msglistentry);
 	spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);
 
+error_gpadl:
+	vmbus_teardown_gpadl(newchannel, newchannel->ringbuffer_gpadlhandle);
+
 error0:
 	free_pages((unsigned long)out,
 		get_order(send_ringbuffer_size + recv_ringbuffer_size));
-- 
1.7.4.1


  parent reply	other threads:[~2015-02-27 18:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 19:25 [PATCH RESEND 00/15] Drivers: hv: vmbus: Miscellaneous fixes/enhancements K. Y. Srinivasan
2015-02-27 19:25 ` [PATCH RESEND 01/15] Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors K. Y. Srinivasan
2015-02-27 19:25   ` [PATCH RESEND 02/15] Drivers: hv: vmbus: rename channel work queues K. Y. Srinivasan
2015-02-27 19:25   ` [PATCH RESEND 03/15] Drivers: hv: vmbus: avoid double kfree for device_obj K. Y. Srinivasan
2015-02-27 19:25   ` [PATCH RESEND 04/15] Drivers: hv: vmbus: teardown hv_vmbus_con workqueue and vmbus_connection pages on shutdown K. Y. Srinivasan
2015-02-27 19:25   ` [PATCH RESEND 05/15] drivers: hv: vmbus: Teardown synthetic interrupt controllers on module unload K. Y. Srinivasan
2015-02-27 19:25   ` [PATCH RESEND 06/15] clockevents: export clockevents_unbind_device instead of clockevents_unbind K. Y. Srinivasan
2015-02-27 19:25   ` [PATCH RESEND 07/15] Drivers: hv: vmbus: Teardown clockevent devices on module unload K. Y. Srinivasan
2015-02-27 19:25   ` [PATCH RESEND 08/15] hv: hv_util: move vmbus_open() to a later place K. Y. Srinivasan
2015-02-27 19:25   ` [PATCH RESEND 09/15] hv: vmbus_post_msg: retry the hypercall on some transient errors K. Y. Srinivasan
2015-02-27 19:26   ` [PATCH RESEND 10/15] hv: vmbus_open(): reset the channel state on ENOMEM K. Y. Srinivasan
2015-02-27 19:26   ` [PATCH RESEND 11/15] hv: channel: match var type to return type of wait_for_completion K. Y. Srinivasan
2015-02-27 19:26   ` [PATCH RESEND 12/15] hv: channel_mgmt: " K. Y. Srinivasan
2015-02-27 19:26   ` [PATCH RESEND 13/15] hv: hv_balloon: " K. Y. Srinivasan
2015-02-27 19:26   ` K. Y. Srinivasan [this message]
2015-02-27 19:26   ` [PATCH RESEND 15/15] Drivers: hv: vmbus: Add support for the NetworkDirect GUID K. Y. Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425065165-21823-14-git-send-email-kys@microsoft.com \
    --to=kys@microsoft.com \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=stable@vger.kernel.org \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®