* [PATCH] of/selftest: remove the duplicate of_changeset_init
@ 2015-03-02 6:49 Wang Long
2015-03-13 15:27 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Wang Long @ 2015-03-02 6:49 UTC (permalink / raw)
To: pantelis.antoniou, grant.likely, robh+dt
Cc: devicetree, linux-kernel, long.wanglong, peifeiyue
Remove the duplicate of_changeset_init. In of_selftest_changeset
testcase, the "struct of_changeset chgset" is initialized twice,
but only once is enough. so, drop the first initializtion code.
Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
drivers/of/unittest.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 0cf9a23..199fb23 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -478,7 +478,6 @@ static void __init of_selftest_changeset(void)
struct device_node *n1, *n2, *n21, *nremove, *parent, *np;
struct of_changeset chgset;
- of_changeset_init(&chgset);
n1 = __of_node_dup(NULL, "/testcase-data/changeset/n1");
selftest(n1, "testcase setup failure\n");
n2 = __of_node_dup(NULL, "/testcase-data/changeset/n2");
--
1.8.3.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] of/selftest: remove the duplicate of_changeset_init
2015-03-02 6:49 [PATCH] of/selftest: remove the duplicate of_changeset_init Wang Long
@ 2015-03-13 15:27 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2015-03-13 15:27 UTC (permalink / raw)
To: Wang Long
Cc: Pantelis Antoniou, Grant Likely, Rob Herring, devicetree,
linux-kernel, peifeiyue
On Mon, Mar 2, 2015 at 12:49 AM, Wang Long <long.wanglong@huawei.com> wrote:
> Remove the duplicate of_changeset_init. In of_selftest_changeset
> testcase, the "struct of_changeset chgset" is initialized twice,
> but only once is enough. so, drop the first initializtion code.
>
> Signed-off-by: Wang Long <long.wanglong@huawei.com>
Applied for 4.0. Thanks.
Rob
> ---
> drivers/of/unittest.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 0cf9a23..199fb23 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -478,7 +478,6 @@ static void __init of_selftest_changeset(void)
> struct device_node *n1, *n2, *n21, *nremove, *parent, *np;
> struct of_changeset chgset;
>
> - of_changeset_init(&chgset);
> n1 = __of_node_dup(NULL, "/testcase-data/changeset/n1");
> selftest(n1, "testcase setup failure\n");
> n2 = __of_node_dup(NULL, "/testcase-data/changeset/n2");
> --
> 1.8.3.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-13 15:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-02 6:49 [PATCH] of/selftest: remove the duplicate of_changeset_init Wang Long
2015-03-13 15:27 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®