mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hou Pengyang <houpengyang@huawei.com>
To: <rostedt@goodmis.org>, <mingo@redhat.com>
Cc: <wangnan0@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] ftrace: Fix comments about trace/ftrace.h
Date: Mon, 2 Mar 2015 14:28:54 +0000	[thread overview]
Message-ID: <1425306534-161763-1-git-send-email-houpengyang@huawei.com> (raw)

commit f42c85e74faa422cf0bc747ed808681145448f88 moves tracepoint's ftrace 
creation into include/trace/ftrace.h and trace/define_trach.h is deleted 
as a result. However some comment info does not adapt to the change, which 
I think is such a misguiding when reading related code. 

This patch fix this comment by moving trace/trace_events.h to TRACE_INCLUDE
(TRACE_INCLUDE_FILE), the macro TRACE_INCLUDE(TRACE_INCLUDE_FILE) is defined
in trace/define_trace.h

Signed-off-by: Hou Pengyang <houpengyang@huawei.com>
---
 include/trace/ftrace.h | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
index 41bf65f..cb78a8b 100644
--- a/include/trace/ftrace.h
+++ b/include/trace/ftrace.h
@@ -1,7 +1,8 @@
 /*
  * Stage 1 of the trace events.
  *
- * Override the macros in <trace/trace_events.h> to include the following:
+ * Override the macros in TRACE_INCLUDE(TRACE_INCLUDE_FILE) to 
+ * include the following:
  *
  * struct ftrace_raw_<call> {
  *	struct trace_entry		ent;
@@ -170,7 +171,8 @@
 /*
  * Stage 3 of the trace events.
  *
- * Override the macros in <trace/trace_events.h> to include the following:
+ * Override the macros in TRACE_INCLUDE(TRACE_INCLUDE_FILE) to 
+ * include the following:
  *
  * enum print_line_t
  * ftrace_raw_output_<call>(struct trace_iterator *iter, int flags)
@@ -479,7 +481,8 @@ static inline notrace int ftrace_get_offsets_##call(			\
 /*
  * Stage 4 of the trace events.
  *
- * Override the macros in <trace/trace_events.h> to include the following:
+ * Override the macros in TRACE_INCLUDE(TRACE_INCLUDE_FILE) to 
+ * include the following:
  *
  * For those macros defined with TRACE_EVENT:
  *
-- 
1.8.3.4


             reply	other threads:[~2015-03-02  6:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 14:28 Hou Pengyang [this message]
2015-03-02 14:10 ` Steven Rostedt
2015-03-03  2:38   ` Hou Pengyang
2015-03-03  4:06     ` Steven Rostedt
2015-03-03 21:48       ` Hou Pengyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425306534-161763-1-git-send-email-houpengyang@huawei.com \
    --to=houpengyang@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®