From: Steven Rostedt <rostedt@goodmis.org>
To: Hou Pengyang <houpengyang@huawei.com>
Cc: <mingo@redhat.com>, <wangnan0@huawei.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace: Fix comments about trace/ftrace.h
Date: Mon, 2 Mar 2015 23:06:09 -0500 [thread overview]
Message-ID: <20150302230609.7a9670c9@grimm.local.home> (raw)
In-Reply-To: <54F51E9B.7020807@huawei.com>
On Tue, 3 Mar 2015 10:38:19 +0800
Hou Pengyang <houpengyang@huawei.com> wrote:
> >> --- a/include/trace/ftrace.h
> >> +++ b/include/trace/ftrace.h
> >> @@ -1,7 +1,8 @@
> >> /*
> >> * Stage 1 of the trace events.
> >> *
> >> - * Override the macros in <trace/trace_events.h> to include the following:
> >> + * Override the macros in TRACE_INCLUDE(TRACE_INCLUDE_FILE) to
> >
> > I agree that the comment needs updating, but not to this.
> > TRACE_INCLUDE(TRACE_INCLUDE_FILE) is not very descriptive. Because
> > nobody understand exactly what that is. Do you?
> >
> > Change it to:
> >
> > Override the macros in the event tracepoint header ...
> >
> > And do that for the ones below too. This is more descriptive than just
> > describing what the code is literally doing.
> >
> > -- Steve
> >
> To be more descriptive, how about "Override the macros in the event
> tracepoint header <trace/events/XXX.h> ..." ? since, tracepoint headers
> have already been moved to trace/events/ .
That's fine with me too.
-- Steve
next prev parent reply other threads:[~2015-03-03 4:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 14:28 Hou Pengyang
2015-03-02 14:10 ` Steven Rostedt
2015-03-03 2:38 ` Hou Pengyang
2015-03-03 4:06 ` Steven Rostedt [this message]
2015-03-03 21:48 ` Hou Pengyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302230609.7a9670c9@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=houpengyang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®