Re: [PATCH] checkkconfigsymbols.py: filter reports for tools/

[Paul Bolle <pebolle@tiscali.nl>]

On Wed, 2015-02-25 at 15:15 +0100, Valentin Rothberg wrote:
> @@ -46,8 +46,9 @@ def main():
>          stdout = stdout[:-1]
>  
>      for gitfile in stdout.rsplit("\n"):
> -        if ".git" in gitfile or "ChangeLog" in gitfile or \
> -                ".log" in gitfile or os.path.isdir(gitfile):
> +        if ".git" in gitfile or "ChangeLog" in gitfile or      \
> +                ".log" in gitfile or os.path.isdir(gitfile) or \
> +                gitfile.startswith("tools/"):

Perhaps just
    gitfile == "tools/perf/config/Makefile"

(but I'm unsure if that's valid python)? 

>              continue
>          if REGEX_FILE_KCONFIG.match(gitfile):
>              kconfig_files.append(gitfile)

This patch was triggered by perf changes that hit next-20150225, wasn't
it? If so, we might want to find out why the perf people need to use
their
    "$(call detected,CONFIG_EXAMPLE)"

hack. Especially because that hack is also used on existing Kconfig
symbols (I spotted X86, X86_64, AUDIT, and NUMA). And the usage of both
valid Kconfig macros and faux Kconfig macros in that hack looks odd to
me.


Paul Bolle