[PATCH V2] bgmac: Clean warning messages

[PATCH V2] bgmac: Clean warning messages

[Peter Senna Tschudin]

On my test environment the throughput of a file transfer drops
from 4.4MBps to 116KBps due the number of repeated warning
messages. This patch removes the warning messages as DMA works
correctly with addresses using 0xC0000000 bits.

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
Changes from V1:
   - Updated commit message. Thanks Rafał Miłecki <zajec5@gmail.com>

Changes from: bgmac: ratelimit warning messages
   - Remove the messages instead of using printk_ratelimit()

 drivers/net/ethernet/broadcom/bgmac.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index 676ffe0..0469f72 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -302,9 +302,6 @@ static int bgmac_dma_rx_skb_for_slot(struct bgmac *bgmac,
 	slot->skb = skb;
 	slot->dma_addr = dma_addr;
 
-	if (slot->dma_addr & 0xC0000000)
-		bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
-
 	return 0;
 }
 
@@ -505,8 +502,6 @@ static int bgmac_dma_alloc(struct bgmac *bgmac)
 				  ring->mmio_base);
 			goto err_dma_free;
 		}
-		if (ring->dma_base & 0xC0000000)
-			bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
 
 		ring->unaligned = bgmac_dma_unaligned(bgmac, ring,
 						      BGMAC_DMA_RING_TX);
@@ -536,8 +531,6 @@ static int bgmac_dma_alloc(struct bgmac *bgmac)
 			err = -ENOMEM;
 			goto err_dma_free;
 		}
-		if (ring->dma_base & 0xC0000000)
-			bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
 
 		ring->unaligned = bgmac_dma_unaligned(bgmac, ring,
 						      BGMAC_DMA_RING_RX);
-- 
2.1.0

Re: [PATCH V2] bgmac: Clean warning messages

[Rafał Miłecki]

On 7 March 2015 at 12:10, Peter Senna Tschudin <peter.senna@gmail.com> wrote:
> On my test environment the throughput of a file transfer drops
> from 4.4MBps to 116KBps due the number of repeated warning
> messages. This patch removes the warning messages as DMA works
> correctly with addresses using 0xC0000000 bits.
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>

Acked-by: Rafał Miłecki <zajec5@gmail.com>

Re: [PATCH V2] bgmac: Clean warning messages

[David Miller]

From: Peter Senna Tschudin <peter.senna@gmail.com>
Date: Sat,  7 Mar 2015 12:10:26 +0100

> On my test environment the throughput of a file transfer drops
> from 4.4MBps to 116KBps due the number of repeated warning
> messages. This patch removes the warning messages as DMA works
> correctly with addresses using 0xC0000000 bits.
> 
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> Changes from V1:
>    - Updated commit message. Thanks Rafał Miłecki <zajec5@gmail.com>

Applied, thanks.