mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: keescook@chromium.org, yinghai@kernel.org, hpa@zytor.com,
	mingo@redhat.com, bp@suse.de, matt.fleming@intel.com,
	vgoyal@redhat.com, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, Baoquan He <bhe@redhat.com>
Subject: [Patch v3 1/7] x86, kaslr: Fix a bug that relocation can not be handled when kernel is loaded above 2G
Date: Sun,  8 Mar 2015 13:38:49 +0800	[thread overview]
Message-ID: <1425793135-2833-2-git-send-email-bhe@redhat.com> (raw)
In-Reply-To: <1425793135-2833-1-git-send-email-bhe@redhat.com>

When process 32 bit relocation tables a local variable extended is
defined to calculate the physical address of relocs entry. However
it's type is int which is enough for i386, for x86_64 not enough.
That's why relocation can only be handled when kernel is loaded
below 2G, otherwise a overflow will happen and cause system hang.

Here change it to long as 32 bit inverse relocation processing does,
and this change is safe for i386 relocation handling too.

Signed-off-by: Baoquan He <bhe@redhat.com>
---
 arch/x86/boot/compressed/misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
index 51e9e54..f3ca33e 100644
--- a/arch/x86/boot/compressed/misc.c
+++ b/arch/x86/boot/compressed/misc.c
@@ -278,7 +278,7 @@ static void handle_relocations(void *output, unsigned long output_len)
 	 * So we work backwards from the end of the decompressed image.
 	 */
 	for (reloc = output + output_len - sizeof(*reloc); *reloc; reloc--) {
-		int extended = *reloc;
+		long extended = *reloc;
 		extended += map;
 
 		ptr = (unsigned long)extended;
-- 
1.9.3


  reply	other threads:[~2015-03-08  5:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-08  5:38 [Patch v3 0/7] randomize kernel physical address and virtual address separately Baoquan He
2015-03-08  5:38 ` Baoquan He [this message]
2015-03-08  5:38 ` [Patch v3 2/7] x86, kaslr: Introduce struct slot_area to manage randomization slot info Baoquan He
2015-03-08  5:38 ` [Patch v3 3/7] x86, kaslr: Add two functions which will be used later Baoquan He
2015-03-08 13:58   ` Alexander Kuleshov
2015-03-09 12:40     ` Baoquan He
2015-03-08  5:38 ` [Patch v3 4/7] x86, kaslr: Introduce fetch_random_virt_offset to randomize the kernel text mapping address Baoquan He
2015-03-08  5:38 ` [Patch v3 5/7] x86, kaslr: Randomize physical and virtual address of kernel separately Baoquan He
2015-03-08  5:38 ` [Patch v3 6/7] x86, kaslr: Add support of kernel physical address randomization above 4G Baoquan He
2015-03-08  5:38 ` [Patch v3 7/7] x86, kaslr: Remove useless codes Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425793135-2833-2-git-send-email-bhe@redhat.com \
    --to=bhe@redhat.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®