From: Baoquan He <bhe@redhat.com>
To: keescook@chromium.org, yinghai@kernel.org, hpa@zytor.com,
mingo@redhat.com, bp@suse.de, matt.fleming@intel.com,
vgoyal@redhat.com, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, Baoquan He <bhe@redhat.com>
Subject: [Patch v3 7/7] x86, kaslr: Remove useless codes
Date: Sun, 8 Mar 2015 13:38:55 +0800 [thread overview]
Message-ID: <1425793135-2833-8-git-send-email-bhe@redhat.com> (raw)
In-Reply-To: <1425793135-2833-1-git-send-email-bhe@redhat.com>
Several auxiliary functions and slots[] are not needed any more since
struct slot_area is used to store the slot info of kaslr now. Hence
remove them in this patch.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
arch/x86/boot/compressed/aslr.c | 24 ------------------------
1 file changed, 24 deletions(-)
diff --git a/arch/x86/boot/compressed/aslr.c b/arch/x86/boot/compressed/aslr.c
index 2cf8f82..ce6ee28 100644
--- a/arch/x86/boot/compressed/aslr.c
+++ b/arch/x86/boot/compressed/aslr.c
@@ -126,17 +126,6 @@ struct mem_vector {
#define MEM_AVOID_MAX 4
static struct mem_vector mem_avoid[MEM_AVOID_MAX];
-static bool mem_contains(struct mem_vector *region, struct mem_vector *item)
-{
- /* Item at least partially before region. */
- if (item->start < region->start)
- return false;
- /* Item at least partially after region. */
- if (item->start + item->size > region->start + region->size)
- return false;
- return true;
-}
-
static bool mem_overlaps(struct mem_vector *one, struct mem_vector *two)
{
/* Item one is entirely before item two. */
@@ -264,9 +253,6 @@ mem_min_overlap(struct mem_vector *img, struct mem_vector *out)
return min;
}
-static unsigned long slots[CONFIG_RANDOMIZE_BASE_MAX_OFFSET /
- CONFIG_PHYSICAL_ALIGN];
-
struct slot_area {
unsigned long addr;
int num;
@@ -297,16 +283,6 @@ static void store_slot_info(struct mem_vector *region, unsigned long image_size)
}
}
-static void slots_append(unsigned long addr)
-{
- /* Overflowing the slots list should be impossible. */
- if (slot_max >= CONFIG_RANDOMIZE_BASE_MAX_OFFSET /
- CONFIG_PHYSICAL_ALIGN)
- return;
-
- slots[slot_max++] = addr;
-}
-
static unsigned long slots_fetch_random(void)
{
unsigned long random;
--
1.9.3
prev parent reply other threads:[~2015-03-08 5:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 5:38 [Patch v3 0/7] randomize kernel physical address and virtual address separately Baoquan He
2015-03-08 5:38 ` [Patch v3 1/7] x86, kaslr: Fix a bug that relocation can not be handled when kernel is loaded above 2G Baoquan He
2015-03-08 5:38 ` [Patch v3 2/7] x86, kaslr: Introduce struct slot_area to manage randomization slot info Baoquan He
2015-03-08 5:38 ` [Patch v3 3/7] x86, kaslr: Add two functions which will be used later Baoquan He
2015-03-08 13:58 ` Alexander Kuleshov
2015-03-09 12:40 ` Baoquan He
2015-03-08 5:38 ` [Patch v3 4/7] x86, kaslr: Introduce fetch_random_virt_offset to randomize the kernel text mapping address Baoquan He
2015-03-08 5:38 ` [Patch v3 5/7] x86, kaslr: Randomize physical and virtual address of kernel separately Baoquan He
2015-03-08 5:38 ` [Patch v3 6/7] x86, kaslr: Add support of kernel physical address randomization above 4G Baoquan He
2015-03-08 5:38 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425793135-2833-8-git-send-email-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®