From: Wolfram Sang <wsa@the-dreams.de>
To: linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-sh@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: [PATCH] kernfs: remove outdated and confusing comment
Date: Wed, 11 Mar 2015 11:26:02 +0100 [thread overview]
Message-ID: <1426069565-7933-1-git-send-email-wsa@the-dreams.de> (raw)
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Grabbing the parent is not happening anymore since 2010 (e72ceb8ccac5f7
"sysfs: Remove sysfs_get/put_active_two"). Remove this confusing
comment.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Found while trying to find out why my sysfs-bin file always returns POLLPRI
after opening, reading, polling. Any pointers while I am here? :)
fs/kernfs/file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index b684e8a132e625..a893c634cd9c0b 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -784,7 +784,6 @@ static unsigned int kernfs_fop_poll(struct file *filp, poll_table *wait)
struct kernfs_node *kn = filp->f_path.dentry->d_fsdata;
struct kernfs_open_node *on = kn->attr.open;
- /* need parent for the kobj, grab both */
if (!kernfs_get_active(kn))
goto trigger;
--
2.1.4
next reply other threads:[~2015-03-11 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 10:26 Wolfram Sang [this message]
2015-03-11 11:45 ` Tejun Heo
2015-03-11 13:15 ` Wolfram Sang
2015-04-23 12:51 ` Wolfram Sang
2015-04-23 14:56 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426069565-7933-1-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®