mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] kernfs: remove outdated and confusing comment
Date: Wed, 11 Mar 2015 07:45:31 -0400	[thread overview]
Message-ID: <20150311114531.GB25944@htj.duckdns.org> (raw)
In-Reply-To: <1426069565-7933-1-git-send-email-wsa@the-dreams.de>

On Wed, Mar 11, 2015 at 11:26:02AM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Grabbing the parent is not happening anymore since 2010 (e72ceb8ccac5f7
> "sysfs: Remove sysfs_get/put_active_two"). Remove this confusing
> comment.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Acked-by: Tejun Heo <tj@kernel.org>

> Found while trying to find out why my sysfs-bin file always returns POLLPRI
> after opening, reading, polling. Any pointers while I am here? :)

Hmm... poll isn't hooked up for bin files and the behavior isn't well
defined either.  The open file's event counter is never synchronized
to the backing node's.  Before the first kernfs_notify(), it won't
trigger and after always.  We'll prolly need to define that better.
What's the use case that you're interested in?

Thanks.

-- 
tejun

  reply	other threads:[~2015-03-11 11:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 10:26 Wolfram Sang
2015-03-11 11:45 ` Tejun Heo [this message]
2015-03-11 13:15   ` Wolfram Sang
2015-04-23 12:51   ` Wolfram Sang
2015-04-23 14:56     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150311114531.GB25944@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®