From: Markus Pargmann <mpa@pengutronix.de>
To: nbd-general@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Wouter Verhelst <w@uter.be>, Markus Pargmann <mpa@pengutronix.de>
Subject: [PATCH v2 3/9] nbd: Remove kernel internal header
Date: Thu, 12 Mar 2015 14:36:01 +0100 [thread overview]
Message-ID: <1426167367-32214-4-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1426167367-32214-1-git-send-email-mpa@pengutronix.de>
The header is not included anywhere. Remove it and include the private
nbd_device struct in nbd.c.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
drivers/block/nbd.c | 22 ++++++++++++++++++++++
include/linux/nbd.h | 46 ----------------------------------------------
2 files changed, 22 insertions(+), 46 deletions(-)
delete mode 100644 include/linux/nbd.h
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 4bc2a5cb9935..58c2b20ad17b 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -38,6 +38,28 @@
#include <linux/nbd.h>
+struct nbd_device {
+ int flags;
+ int harderror; /* Code of hard error */
+ struct socket * sock; /* If == NULL, device is not ready, yet */
+ int magic;
+
+ spinlock_t queue_lock;
+ struct list_head queue_head; /* Requests waiting result */
+ struct request *active_req;
+ wait_queue_head_t active_wq;
+ struct list_head waiting_queue; /* Requests to be sent */
+ wait_queue_head_t waiting_wq;
+
+ struct mutex tx_lock;
+ struct gendisk *disk;
+ int blksize;
+ u64 bytesize;
+ pid_t pid; /* pid of nbd-client, if attached */
+ int xmit_timeout;
+ int disconnect; /* a disconnect has been requested by user */
+};
+
#define NBD_MAGIC 0x68797548
#ifdef NDEBUG
diff --git a/include/linux/nbd.h b/include/linux/nbd.h
deleted file mode 100644
index f62f78aef4ac..000000000000
--- a/include/linux/nbd.h
+++ /dev/null
@@ -1,46 +0,0 @@
-/*
- * 1999 Copyright (C) Pavel Machek, pavel@ucw.cz. This code is GPL.
- * 1999/11/04 Copyright (C) 1999 VMware, Inc. (Regis "HPReg" Duchesne)
- * Made nbd_end_request() use the io_request_lock
- * 2001 Copyright (C) Steven Whitehouse
- * New nbd_end_request() for compatibility with new linux block
- * layer code.
- * 2003/06/24 Louis D. Langholtz <ldl@aros.net>
- * Removed unneeded blksize_bits field from nbd_device struct.
- * Cleanup PARANOIA usage & code.
- * 2004/02/19 Paul Clements
- * Removed PARANOIA, plus various cleanup and comments
- */
-#ifndef LINUX_NBD_H
-#define LINUX_NBD_H
-
-
-#include <linux/wait.h>
-#include <linux/mutex.h>
-#include <uapi/linux/nbd.h>
-
-struct request;
-
-struct nbd_device {
- int flags;
- int harderror; /* Code of hard error */
- struct socket * sock; /* If == NULL, device is not ready, yet */
- int magic;
-
- spinlock_t queue_lock;
- struct list_head queue_head; /* Requests waiting result */
- struct request *active_req;
- wait_queue_head_t active_wq;
- struct list_head waiting_queue; /* Requests to be sent */
- wait_queue_head_t waiting_wq;
-
- struct mutex tx_lock;
- struct gendisk *disk;
- int blksize;
- u64 bytesize;
- pid_t pid; /* pid of nbd-client, if attached */
- int xmit_timeout;
- int disconnect; /* a disconnect has been requested by user */
-};
-
-#endif
--
2.1.4
next prev parent reply other threads:[~2015-03-12 13:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 13:35 [PATCH v2 0/9] nbd: cleanups Markus Pargmann
2015-03-12 13:35 ` [PATCH v2 1/9] Documentation: nbd: Reformat to allow more documentation Markus Pargmann
2015-03-12 13:36 ` [PATCH v2 2/9] Documentation: nbd: Add list of module parameters Markus Pargmann
2015-03-12 13:36 ` Markus Pargmann [this message]
2015-03-12 13:36 ` [PATCH v2 4/9] nbd: Replace kthread_create with kthread_run Markus Pargmann
2015-03-16 21:11 ` Pavel Machek
2015-03-12 13:36 ` [PATCH v2 5/9] nbd: Fix device bytesize type Markus Pargmann
2015-03-16 21:11 ` Pavel Machek
2015-03-12 13:36 ` [PATCH v2 6/9] nbd: Restructure debugging prints Markus Pargmann
2015-03-16 21:11 ` Pavel Machek
2015-03-12 13:36 ` [PATCH v2 7/9] nbd: Remove fixme that was already fixed Markus Pargmann
2015-03-12 13:36 ` [PATCH v2 8/9] nbd: Return error code directly Markus Pargmann
2015-03-16 21:11 ` Pavel Machek
2015-03-12 13:36 ` [PATCH v2 9/9] nbd: Return error pointer directly Markus Pargmann
2015-03-16 21:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426167367-32214-4-git-send-email-mpa@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd-general@lists.sourceforge.net \
--cc=w@uter.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®