From: Markus Pargmann <mpa@pengutronix.de>
To: nbd-general@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Wouter Verhelst <w@uter.be>, Markus Pargmann <mpa@pengutronix.de>
Subject: [PATCH v2 7/9] nbd: Remove fixme that was already fixed
Date: Thu, 12 Mar 2015 14:36:05 +0100 [thread overview]
Message-ID: <1426167367-32214-8-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1426167367-32214-1-git-send-email-mpa@pengutronix.de>
The mentioned problem is not present anymore.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
drivers/block/nbd.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 217b570dd7a5..6e7a7b06efcb 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -110,14 +110,11 @@ static void nbd_end_request(struct nbd_device *nbd, struct request *req)
spin_unlock_irqrestore(q->queue_lock, flags);
}
+/*
+ * Forcibly shutdown the socket causing all listeners to error
+ */
static void sock_shutdown(struct nbd_device *nbd, int lock)
{
- /* Forcibly shutdown the socket causing all listeners
- * to error
- *
- * FIXME: This code is duplicated from sys_shutdown, but
- * there should be a more generic interface rather than
- * calling socket ops directly here */
if (lock)
mutex_lock(&nbd->tx_lock);
if (nbd->sock) {
--
2.1.4
next prev parent reply other threads:[~2015-03-12 13:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 13:35 [PATCH v2 0/9] nbd: cleanups Markus Pargmann
2015-03-12 13:35 ` [PATCH v2 1/9] Documentation: nbd: Reformat to allow more documentation Markus Pargmann
2015-03-12 13:36 ` [PATCH v2 2/9] Documentation: nbd: Add list of module parameters Markus Pargmann
2015-03-12 13:36 ` [PATCH v2 3/9] nbd: Remove kernel internal header Markus Pargmann
2015-03-12 13:36 ` [PATCH v2 4/9] nbd: Replace kthread_create with kthread_run Markus Pargmann
2015-03-16 21:11 ` Pavel Machek
2015-03-12 13:36 ` [PATCH v2 5/9] nbd: Fix device bytesize type Markus Pargmann
2015-03-16 21:11 ` Pavel Machek
2015-03-12 13:36 ` [PATCH v2 6/9] nbd: Restructure debugging prints Markus Pargmann
2015-03-16 21:11 ` Pavel Machek
2015-03-12 13:36 ` Markus Pargmann [this message]
2015-03-12 13:36 ` [PATCH v2 8/9] nbd: Return error code directly Markus Pargmann
2015-03-16 21:11 ` Pavel Machek
2015-03-12 13:36 ` [PATCH v2 9/9] nbd: Return error pointer directly Markus Pargmann
2015-03-16 21:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426167367-32214-8-git-send-email-mpa@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd-general@lists.sourceforge.net \
--cc=w@uter.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®