mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Martin Walch <walch.martin@web.de>
Cc: Wang YanQing <udknight@gmail.com>,
	davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	j.vosburgh@gmail.com, vfalico@gmail.com,
	gospo@cumulusnetworks.com, Erik Hugne <erik.hugne@ericsson.com>
Subject: Re: [PATCH] net:Kconfig: drop no sense dependence entry for BONDING
Date: Thu, 12 Mar 2015 10:30:44 -0700	[thread overview]
Message-ID: <1426181444.11398.167.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <5969250.CkvXFhddBO@tacticalops>

On Thu, 2015-03-12 at 16:14 +0100, Martin Walch wrote:
> On Thursday 12 March 2015 21:59:33 Wang YanQing wrote:
> > "IPV6 || IPV6=n" means no dependence!
> 
> IPV6 and BONDING are both tristate symbols and therefore this is not the same
> as no dependency. When setting IPV6 to m, the expression evaluates to
> 
> "IPV6 || IPV6=n" 
> "m || m=n"
> "m || n"
> "m"
> 
> So, if IPV6=m, then BONDING can only be n or m, but not y.

Right.

But it looks like bonding driver no longer has IPV6 dependencies.

Patch should work, but the changelog should be changed to explain why
the patch is valid, and this should be tested.

Presumably we need to make sure the following builds and runs properly

CONFIG_BONDING=y
CONFIG_IPV6=m




  reply	other threads:[~2015-03-12 17:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 13:59 Wang YanQing
2015-03-12 14:13 ` Erik Hugne
2015-03-12 15:14 ` Martin Walch
2015-03-12 17:30   ` Eric Dumazet [this message]
2015-03-12 18:15 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426181444.11398.167.camel@edumazet-glaptop2.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=erik.hugne@ericsson.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=j.vosburgh@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=udknight@gmail.com \
    --cc=vfalico@gmail.com \
    --cc=walch.martin@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®