From: David Miller <davem@davemloft.net>
To: udknight@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, j.vosburgh@gmail.com,
vfalico@gmail.com, gospo@cumulusnetworks.com
Subject: Re: [PATCH] net:Kconfig: drop no sense dependence entry for BONDING
Date: Thu, 12 Mar 2015 14:15:56 -0400 (EDT) [thread overview]
Message-ID: <20150312.141556.780781968181122546.davem@davemloft.net> (raw)
In-Reply-To: <20150312135933.GA3502@udknight>
From: Wang YanQing <udknight@gmail.com>
Date: Thu, 12 Mar 2015 21:59:33 +0800
> "IPV6 || IPV6=n" means no dependence!
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
It is only nonsense because you don't actually understand what the
statement does.
It makes sure that either IPV6 is enabled and _EQUALS_ what BONDING is
set to ("y" _or_ "m"), or it is disabled.
This pattern is used all over the place and is quite common actually.
Better to first ask what a statement does, than to knee-jerk submit a
patch to remove it. Because patch submissions use up people's
resources and time, particularly mine.
prev parent reply other threads:[~2015-03-12 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 13:59 Wang YanQing
2015-03-12 14:13 ` Erik Hugne
2015-03-12 15:14 ` Martin Walch
2015-03-12 17:30 ` Eric Dumazet
2015-03-12 18:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312.141556.780781968181122546.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@cumulusnetworks.com \
--cc=j.vosburgh@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=udknight@gmail.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®