mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: <trivial@kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Scott Wood <scottwood@freescale.com>,
	<sparclinux@vger.kernel.org>, "Sam Ravnborg" <sam@ravnborg.org>
Subject: [PATCH v2 12/22] sparc: %pf is only for function pointers
Date: Thu, 12 Mar 2015 16:45:59 -0500	[thread overview]
Message-ID: <1426196761-4891-1-git-send-email-scottwood@freescale.com> (raw)

Use %ps for actual addresses, otherwise you'll get bad output
on arches like ppc64 where %pf expects a function descriptor.  Even on
other architectures, refrain from setting a bad example that people
copy.

Signed-off-by: Scott Wood <scottwood@freescale.com>
Cc: sparclinux@vger.kernel.org
Cc: Sam Ravnborg <sam@ravnborg.org>
---
v2: Fix commit message to reflect that this patch is about %pf, not %pF.

 arch/sparc/kernel/ds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sparc/kernel/ds.c b/arch/sparc/kernel/ds.c
index f87a55d..4ff835f 100644
--- a/arch/sparc/kernel/ds.c
+++ b/arch/sparc/kernel/ds.c
@@ -875,7 +875,7 @@ void ldom_power_off(void)
 
 static void ds_conn_reset(struct ds_info *dp)
 {
-	printk(KERN_ERR "ds-%llu: ds_conn_reset() from %pf\n",
+	printk(KERN_ERR "ds-%llu: ds_conn_reset() from %ps\n",
 	       dp->id, __builtin_return_address(0));
 }
 
-- 
2.1.0


             reply	other threads:[~2015-03-12 21:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 21:45 Scott Wood [this message]
2015-03-12 21:46 ` [PATCH v2 14/22] parisc: " Scott Wood
2015-03-12 21:46 ` [PATCH v2 18/22] usb: gadget: serial: " Scott Wood
2015-03-12 22:02   ` Fabio Estevam
2015-03-14  7:47 ` [PATCH v2 12/22] sparc: " Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426196761-4891-1-git-send-email-scottwood@freescale.com \
    --to=scottwood@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®