From: Scott Wood <scottwood@freescale.com>
To: <trivial@kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Scott Wood <scottwood@freescale.com>, <linux-usb@vger.kernel.org>,
"Felipe Balbi" <balbi@ti.com>, Fabio Estevam <festevam@gmail.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: [PATCH v2 18/22] usb: gadget: serial: %pf is only for function pointers
Date: Thu, 12 Mar 2015 16:46:01 -0500 [thread overview]
Message-ID: <1426196761-4891-3-git-send-email-scottwood@freescale.com> (raw)
In-Reply-To: <1426196761-4891-1-git-send-email-scottwood@freescale.com>
Use %ps for actual addresses, otherwise you'll get bad output
on arches like ppc64 where %pf expects a function descriptor
(which is not what __builtin_return_address returns).
Signed-off-by: Scott Wood <scottwood@freescale.com>
Cc: linux-usb@vger.kernel.org
Cc: Felipe Balbi <balbi@ti.com>
Cc: Fabio Estevam <festevam@gmail.com>
CC: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
v2: Fix commit message to reflect that this patch is about %pf, not %pF,
and to clarify (as requested) that __builtin_return_address does not
return a function pointer.
drivers/usb/gadget/function/u_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c
index 491082a..89179ab 100644
--- a/drivers/usb/gadget/function/u_serial.c
+++ b/drivers/usb/gadget/function/u_serial.c
@@ -912,7 +912,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch)
unsigned long flags;
int status;
- pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n",
+ pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %ps\n",
port->port_num, tty, ch, __builtin_return_address(0));
spin_lock_irqsave(&port->port_lock, flags);
--
2.1.0
next prev parent reply other threads:[~2015-03-12 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 21:45 [PATCH v2 12/22] sparc: " Scott Wood
2015-03-12 21:46 ` [PATCH v2 14/22] parisc: " Scott Wood
2015-03-12 21:46 ` Scott Wood [this message]
2015-03-12 22:02 ` [PATCH v2 18/22] usb: gadget: serial: " Fabio Estevam
2015-03-14 7:47 ` [PATCH v2 12/22] sparc: " Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426196761-4891-3-git-send-email-scottwood@freescale.com \
--to=scottwood@freescale.com \
--cc=balbi@ti.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®