From: Martin Kepplinger <martink@posteo.de>
To: stefanr@s5r6.in-berlin.de
Cc: linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Martin Kepplinger <martink@posteo.de>
Subject: [PATCH] [RFC] firewire: nosy: simplify grabbing context pointer in open()
Date: Fri, 13 Mar 2015 18:33:40 +0100 [thread overview]
Message-ID: <1426268020-5923-1-git-send-email-martink@posteo.de> (raw)
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
This is a question: What's the real difference between the two solutions?
I'm not sure if they are equivalent :(
drivers/firewire/nosy.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c
index 76b2d39..f43619e 100644
--- a/drivers/firewire/nosy.c
+++ b/drivers/firewire/nosy.c
@@ -275,16 +275,12 @@ set_phy_reg(struct pcilynx *lynx, int addr, int val)
static int
nosy_open(struct inode *inode, struct file *file)
{
- int minor = iminor(inode);
struct client *client;
- struct pcilynx *tmp, *lynx = NULL;
+ struct pcilynx *lynx = NULL;
mutex_lock(&card_mutex);
- list_for_each_entry(tmp, &card_list, link)
- if (tmp->misc.minor == minor) {
- lynx = lynx_get(tmp);
- break;
- }
+ lynx = container_of(file->private_data, struct pcilynx, misc);
+ lynx = lynx_get(lynx);
mutex_unlock(&card_mutex);
if (lynx == NULL)
return -ENODEV;
--
2.1.4
reply other threads:[~2015-03-13 17:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426268020-5923-1-git-send-email-martink@posteo.de \
--to=martink@posteo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®