From: Alexander Kuleshov <kuleshovmail@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Cc: Alexander Kuleshov <kuleshovmail@gmail.com>
Subject: [PATCH] perf/builtin-diff: remove unnecessary error output
Date: Sat, 14 Mar 2015 00:19:14 +0600 [thread overview]
Message-ID: <1426270754-11767-1-git-send-email-kuleshovmail@gmail.com> (raw)
This patch prevents duplicated error output. per_session__new function calls
perf_data_file__open which will print error message if it can not open the file
and we will get duplicated output of the error message:
failed to open perf.data.old: No such file or directory
Failed to open perf.data.old
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
tools/perf/builtin-diff.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 74aada5..a18bf98 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -742,7 +742,6 @@ static int __cmd_diff(void)
data__for_each_file(i, d) {
d->session = perf_session__new(&d->file, false, &tool);
if (!d->session) {
- pr_err("Failed to open %s\n", d->file.path);
ret = -1;
goto out_delete;
}
--
2.3.1.291.g7a9409c
reply other threads:[~2015-03-13 18:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426270754-11767-1-git-send-email-kuleshovmail@gmail.com \
--to=kuleshovmail@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®