From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
joe@perches.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v5 00/11] staging: rtl8192e: fix coding style issues
Date: Tue, 17 Mar 2015 00:00:47 +0100 [thread overview]
Message-ID: <1426546858-25212-1-git-send-email-mateusz.kulikowski@gmail.com> (raw)
Various coding style fixes for rtl8192e driver.
This series of patches includes v4,
was rebased on staging-testing branch (9a836c0a)
Changes in v5:
- Suggestions by Joe Perches (Thanks!):
+ Remove unused macros (8/11)
+ Refactored CURRENT_RATE (11/11)
- Removed unused header -rtllib_endianfree.h (6/11)
- Removed dead code - commented-out structures (7/11)
- Removed implementation of container_of (9/11)
- Removed eqMacAddr macro - there is no need to use as Linux already has function to do it
checkpatch.pl still complains about some of patches - this will be fixed
in future (warnings were mostly already there):
1/11:
- usage of subsystem messages instead of printk (fixed in 5/5)
- line over 80 characters (string)
2/11, 10/11:
- line over 80 characters (fix would need re-indentation)
6/11:
- deleted file
Mateusz Kulikowski (11):
staging: rtl8192e: fix coding style issues (merge broken strings)
staging: rtl8192e: fix coding style issues (spaces before semicolon)
staging: rtl8192e: fix coding style errors (macros in parentheses)
staging: rtl8192e: rtllib_wx: remove duplicate messages
staging: rtl8192e: fix coding style warnings (printk -> netdev_*)
staging: rtl8192e: remove rtllib_endianfree.h
staging: rtl8192e: remove dead code
staging: rtl8192e: remove unused macros
staging: rtl8192e: rtllib.h: remove duplicated container_of
drivers: staging: rtl8192e: remove eqMacAddr macro
staging: rtl8192e: remove CURRENT_RATE macro
drivers/staging/rtl8192e/dot11d.h | 9 +-
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 51 +++---
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 30 +--
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 128 ++++++-------
.../staging/rtl8192e/rtl8192e/r8192E_firmware.c | 27 +--
drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.h | 14 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 201 +++++++++++----------
drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 22 +--
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 176 +++++++++---------
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 8 +-
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 59 +++---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 8 -
drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 23 ++-
drivers/staging/rtl8192e/rtl8192e/rtl_pm.c | 21 +--
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 36 ++--
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 58 +++---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 77 ++++----
drivers/staging/rtl8192e/rtl819x_HT.h | 47 -----
drivers/staging/rtl8192e/rtl819x_HTProc.c | 34 ++--
drivers/staging/rtl8192e/rtl819x_Qos.h | 18 --
drivers/staging/rtl8192e/rtl819x_TSProc.c | 58 +++---
drivers/staging/rtl8192e/rtllib.h | 42 +----
drivers/staging/rtl8192e/rtllib_crypt.c | 14 +-
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 24 +--
drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 66 +++----
drivers/staging/rtl8192e/rtllib_crypt_wep.c | 11 +-
drivers/staging/rtl8192e/rtllib_debug.h | 2 +-
drivers/staging/rtl8192e/rtllib_endianfree.h | 122 -------------
drivers/staging/rtl8192e/rtllib_rx.c | 74 +++++---
drivers/staging/rtl8192e/rtllib_softmac.c | 162 +++++++++--------
drivers/staging/rtl8192e/rtllib_softmac_wx.c | 9 +-
drivers/staging/rtl8192e/rtllib_tx.c | 54 +++---
drivers/staging/rtl8192e/rtllib_wx.c | 18 +-
33 files changed, 771 insertions(+), 932 deletions(-)
delete mode 100644 drivers/staging/rtl8192e/rtllib_endianfree.h
--
1.8.4.1
next reply other threads:[~2015-03-16 23:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 23:00 Mateusz Kulikowski [this message]
2015-03-16 23:00 ` [PATCH v5 01/11] staging: rtl8192e: fix coding style issues (merge broken strings) Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 02/11] staging: rtl8192e: fix coding style issues (spaces before semicolon) Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 03/11] staging: rtl8192e: fix coding style errors (macros in parentheses) Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 04/11] staging: rtl8192e: rtllib_wx: remove duplicate messages Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 05/11] staging: rtl8192e: fix coding style warnings (printk -> netdev_*) Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 06/11] staging: rtl8192e: remove rtllib_endianfree.h Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 07/11] staging: rtl8192e: remove dead code Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 08/11] staging: rtl8192e: remove unused macros Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 09/11] staging: rtl8192e: rtllib.h: remove duplicated container_of Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 10/11] drivers: staging: rtl8192e: remove eqMacAddr macro Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 11/11] staging: rtl8192e: remove CURRENT_RATE macro Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426546858-25212-1-git-send-email-mateusz.kulikowski@gmail.com \
--to=mateusz.kulikowski@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®