mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
	joe@perches.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v5 11/11] staging: rtl8192e: remove CURRENT_RATE macro
Date: Tue, 17 Mar 2015 00:00:58 +0100	[thread overview]
Message-ID: <1426546858-25212-12-git-send-email-mateusz.kulikowski@gmail.com> (raw)
In-Reply-To: <1426546858-25212-1-git-send-email-mateusz.kulikowski@gmail.com>

CURRENT_RATE macro is used only once in driver. This patch removes it
and adds rtllib_current_rate() static function in file using that macro

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
 drivers/staging/rtl8192e/rtl819x_HT.h | 10 ----------
 drivers/staging/rtl8192e/rtllib_tx.c  | 14 ++++++++++++--
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index cc754e8..f7076d7 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -343,16 +343,6 @@ struct false_alarm_stats {
 extern u8 MCS_FILTER_ALL[16];
 extern u8 MCS_FILTER_1SS[16];
 
-#define PICK_RATE(_nLegacyRate, _nMcsRate)	\
-		((_nMcsRate == 0) ? (_nLegacyRate&0x7f) : (_nMcsRate))
-#define	LEGACY_WIRELESS_MODE	IEEE_MODE_MASK
-
-#define CURRENT_RATE(WirelessMode, LegacyRate, HTRate)	\
-			(((WirelessMode & (LEGACY_WIRELESS_MODE)) != 0) ? \
-			(LegacyRate) : (PICK_RATE(LegacyRate, HTRate)))
-
-
-
 #define	RATE_ADPT_1SS_MASK		0xFF
 #define	RATE_ADPT_2SS_MASK		0xF0
 #define	RATE_ADPT_MCS32_MASK		0x01
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index 7c0af26..f6d0257 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -550,6 +550,17 @@ static int wme_downgrade_ac(struct sk_buff *skb)
 	}
 }
 
+static u8 rtllib_current_rate(struct rtllib_device *ieee)
+{
+	if (ieee->mode & IEEE_MODE_MASK)
+		return ieee->rate;
+
+	if (ieee->HTCurrentOperaRate)
+		return ieee->HTCurrentOperaRate;
+	else
+		return ieee->rate & 0x7F;
+}
+
 int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
 {
 	struct rtllib_device *ieee = (struct rtllib_device *)
@@ -904,8 +915,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
 			if (tcb_desc->bMulticast ||  tcb_desc->bBroadcast)
 				tcb_desc->data_rate = ieee->basic_rate;
 			else
-				tcb_desc->data_rate = CURRENT_RATE(ieee->mode,
-					ieee->rate, ieee->HTCurrentOperaRate);
+				tcb_desc->data_rate = rtllib_current_rate(ieee);
 
 			if (bdhcp) {
 				if (ieee->pHTInfo->IOTAction &
-- 
1.8.4.1


      parent reply	other threads:[~2015-03-16 23:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 23:00 [PATCH v5 00/11] staging: rtl8192e: fix coding style issues Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 01/11] staging: rtl8192e: fix coding style issues (merge broken strings) Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 02/11] staging: rtl8192e: fix coding style issues (spaces before semicolon) Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 03/11] staging: rtl8192e: fix coding style errors (macros in parentheses) Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 04/11] staging: rtl8192e: rtllib_wx: remove duplicate messages Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 05/11] staging: rtl8192e: fix coding style warnings (printk -> netdev_*) Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 06/11] staging: rtl8192e: remove rtllib_endianfree.h Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 07/11] staging: rtl8192e: remove dead code Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 08/11] staging: rtl8192e: remove unused macros Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 09/11] staging: rtl8192e: rtllib.h: remove duplicated container_of Mateusz Kulikowski
2015-03-16 23:00 ` [PATCH v5 10/11] drivers: staging: rtl8192e: remove eqMacAddr macro Mateusz Kulikowski
2015-03-16 23:00 ` Mateusz Kulikowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426546858-25212-12-git-send-email-mateusz.kulikowski@gmail.com \
    --to=mateusz.kulikowski@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®