* [PATCH] checkkconfigsymbols.py: fix sorted output
@ 2015-03-23 17:40 Valentin Rothberg
0 siblings, 0 replies; only message in thread
From: Valentin Rothberg @ 2015-03-23 17:40 UTC (permalink / raw)
To: gregkh; +Cc: stefan.hengelein, linux-kernel, pebolle, Valentin Rothberg
Commit b1a3f243485f ("checkkconfigsymbols.py: make it Git aware")
mistakenly removed to print undefined Kconfig symbols in alphabetical
order. Furthermore, the script does not print anything anymore when the
entire tree is checked (i.e., when no commit is specified).
This patch restores the sorted output and adds the missing print for the
default case. Additionally, the file lists are now sorted as well which
(a) makes it easier to read and (b) makes the output deterministic.
Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
This patch is written against the char-misc-next branch in Greg's
char-misc git tree; the mentioned commit is not yet in linux-next.
The char-misc tree can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
---
scripts/checkkconfigsymbols.py | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
index ce9ca60808b8..74086a583d8d 100755
--- a/scripts/checkkconfigsymbols.py
+++ b/scripts/checkkconfigsymbols.py
@@ -112,14 +112,15 @@ def main():
undefined_b = check_symbols()
# report cases that are present for the commit but not before
- for feature in undefined_b:
+ for feature in sorted(undefined_b):
# feature has not been undefined before
if not feature in undefined_a:
- files = undefined_b.get(feature)
+ files = sorted(undefined_b.get(feature))
print "%s\t%s" % (feature, ", ".join(files))
# check if there are new files that reference the undefined feature
else:
- files = undefined_b.get(feature) - undefined_a.get(feature)
+ files = sorted(undefined_b.get(feature) -
+ undefined_a.get(feature))
if files:
print "%s\t%s" % (feature, ", ".join(files))
@@ -129,8 +130,9 @@ def main():
# default to check the entire tree
else:
undefined = check_symbols()
- for feature in undefined:
- files = undefined.get(feature)
+ for feature in sorted(undefined):
+ files = sorted(undefined.get(feature))
+ print "%s\t%s" % (feature, ", ".join(files))
def execute(cmd):
--
2.1.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-03-23 17:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-23 17:40 [PATCH] checkkconfigsymbols.py: fix sorted output Valentin Rothberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®